doki-master-theme icon indicating copy to clipboard operation
doki-master-theme copied to clipboard

[Theme Request] Rina Tennoji

Open lezzthanthree opened this issue 3 years ago • 10 comments

Who/What do you want to be featured?

I would like to see Rina Tennoji from Love Live! Nijigasaki School Idol Club, since she's into technology and stuff.

What do they look like?

maxresdefault (2) DZ8Qu4VnmwP3zw OWogNBcbfD1CWA z1S838xFc94_-Q

tex_ch0209_sd0003_01_11

What type of theme?

  • [ ] Light Theme
  • [X] Dark Theme

Additional Information (Optional)

We want more Love Live Themes!! xDD Color should at least be comfy. Gray can be the color of the theme, since that's the color of her symbol Rina_Logos

Rina-chan bodo, "fuwawawa"

lezzthanthree avatar Dec 07 '21 07:12 lezzthanthree

Thank you for the suggestion! I'm starting to feel like I actually need to add Love Live! to my watch list.

Unthrottled avatar Dec 10 '21 21:12 Unthrottled

Is there anything that can be helped with as an outsider? I already tried editing some JSON files, but couldn't figure out how to test them in vscode

SophiaH67 avatar Oct 13 '22 18:10 SophiaH67

@marnixah I've included some contributing documentation. https://github.com/doki-theme/doki-theme-vscode/blob/master/CONTRIBUTING.md#contributing

However, I'm going fairly selective about adding some new themes see this comment, as adding a new theme is lot of work both upfront, deploying, maintenance, and I also build the background art

If you are serious about adding this theme then we can discuss some more about what I am expecting.

Unthrottled avatar Oct 13 '22 21:10 Unthrottled

I am serious about adding this theme. I'm just not quite sure where to get started...

~~I've read through the CONTRIBUTING.md you linked, + the README.md's in doki-theme-jetbrains, doki-theme-vscode, doki-master-theme, doki-build-source, doki-master-theme. But cannot get the vscode extension to compile(I do not have a jetbrains license, so can't go the gradlew route). In the vs-code repo, the file src/DokiThemeDefinitions.ts is in the .gitignore, however, I cannot find out how to aquire(or generate) this file.~~

Apart from that the documentation has been really good so thanks for writing all of that out <3

UPDATE: After sleeping I have figured it out and will try to do as much as possible for this theme

SophiaH67 avatar Oct 14 '22 00:10 SophiaH67

Got it, I'm assuming you want to add this theme so you can use it across many platforms? Most of my stuff offers custom asset installation, and I offer a wide variety of themes that can be used in place to match this character. Most characters have similar palettes, which is why I don't just keep adding themes (and because its a lot of work to maintain)

I'll consider a contribution, but only when if/when I start working on my next set of themes (I'm still working some other things that I want finished before I entertain new themes). Please keep in mind that I have to take care of her after your initial work. In addition I am also going to selective as to how the theme looks as well and what art is used.

Unthrottled avatar Oct 14 '22 10:10 Unthrottled

Still some issues(like left sidebar), but so far your framework for this stuff has been a pleasure to use!

What do you think of the following look?

image

Background

Made from

https://www.deviantart.com/alexargentin/art/Rina-Tennoji-Minimalist-833006728

https://www.deviantart.com/lucifer012/art/Rina-Tennoji-Love-Live-Nijigasaki-School-Idol-844684301

https://wallhaven.cc/w/wyxw57

Background Idea(from screenshot): rinabg

SophiaH67 avatar Oct 14 '22 13:10 SophiaH67

(I am working off of emilia theme and have not changed any of the syntax highlighting colors)

SophiaH67 avatar Oct 14 '22 13:10 SophiaH67

@marnixah

I appreciate your enthusiasm, willingness to help out, and kindness.

However, I have decided that I am not currently interested in theme contributions.

I want every theme in my collection to be special to me & a unique addition to my collection.

So at this time, I will not be considering contributions to this this theme (or any other theme) at this moment.

Thank you for understanding.


If the reason you wanted to help out with this is because you wanted to use the theme. Most of my plugins support custom content. Seems you've already figured out enough to make your own. So I'll suggest you make your own custom theme & use that. That way it's special to you :)

That being said, if you did want to make a contribution in some way, I can find something for you to do.

Unthrottled avatar Oct 15 '22 12:10 Unthrottled

Thanks for the response, I do get it takes a lot of time to maintain all these themes so no worries.

I have indeed found the custom theming options in vscode, but they do not appear to be as robust in the browser and hyper (as quick examples).

As for the last part, I don't mind helping around if there's something that can be done to help yeah

SophiaH67 avatar Oct 15 '22 13:10 SophiaH67

@marnixah Great, thanks for understanding! I'll tag you In an issue (I might be able to create it this weekend), and we can take it from there.

Unthrottled avatar Oct 17 '22 22:10 Unthrottled