AndroTainer icon indicating copy to clipboard operation
AndroTainer copied to clipboard

Log colour support

Open Byter09 opened this issue 2 years ago • 7 comments

First off, I'm a big fan of this app. Makes it so much easier than having to open Portainer in my browser when I'm on the go :D

Secondly, I'm missing a restart feature but it seems #34 already exists haha.

Now for my actual issue. Some containers I run use colours to more clearly identify the various statuses of their messages, like "INFO" or "ERROR". They seem to use ANSI colours. Is that something you could also support in the app? Or at least remove those characters, so that the log looks a bit cleaner?

Thanks again for this app, have a great weekend!

Byter09 avatar Mar 11 '22 14:03 Byter09

Hi Kevin,

As for the logs, I had a lot of issues cleaning up the response from the api. For some reason, the rest client for android didn't parse the log messages properly, so I had to remove all color coding info.

As for the restart functionality, I can implement it, but it won't be an elegant solution, since there is no status "restart" for the docker container. So if you choose restart, you would see "exiting" and then "starting" statuses in succession, which might confuse users, instead of just "restarting".

Regards, Z

On Fri, Mar 11, 2022, 15:40 Kevin Becker @.***> wrote:

First off, I'm a big fan of this app. Makes it so much easier than having to open Portainer in my browser when I'm on the go :D

Secondly, I'm missing a restart feature but it seems #34 https://github.com/dokeraj/AndroTainer/issues/34 already exists haha.

Now for my actual issue. Some containers I run use colours to more clearly identify the various statuses of their messages, like "INFO" or "ERROR". They seem to use ANSI colours. Is that something you could also support in the app? Or at least remove those characters, so that the log looks a bit cleaner?

Thanks again for this app, have a great weekend!

— Reply to this email directly, view it on GitHub https://github.com/dokeraj/AndroTainer/issues/42, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIMHOQEUNWOWZCVDUUEBD3U7NLL5ANCNFSM5QPZ3MWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

dokeraj avatar Mar 12 '22 18:03 dokeraj

Hey.

Okay let's say we can't have colours because Android is at fault, fine by me, but is there a way to clean up and remove colour control characters? Because this is basically unreadable: Screenshot_2022-03-12-19-42-57-29_08cfa81330ea28674f3b052ecfd5bcf3

I can of course disable colours for some apps, but would like to keep them for others when I use them with portainer for a quick overview of what's going on. And in this case it is one of those and sadly barely readable haha :D

I understand though, if this impossible to solve, and I wouldn't mind closing this issue. Just figured I'd ask :)

Thanks for all the work you put into it!

Byter09 avatar Mar 12 '22 18:03 Byter09

Oh, I thought I fixed that issue.

I will run marvin container and see why it's showing those characters

On Sat, Mar 12, 2022, 19:46 Kevin Becker @.***> wrote:

Hey.

Okay let's say we can't have colours because Android is at fault, fine by me, but is there a way to clean up and remove colour control characters? Because this is basically unreadable: [image: Screenshot_2022-03-12-19-42-57-29_08cfa81330ea28674f3b052ecfd5bcf3] https://user-images.githubusercontent.com/16060697/158030792-e66a4af3-568e-4ac8-a3fd-7ac8b1226b0d.jpg

I can of course disable colours for some apps, but would like to keep them for others when I use them with portainer for a quick overview of what's going on. And in this case it is one of those and sadly barely readable haha :D

I understand though, if this impossible to solve, and I wouldn't mind closing this issue. Just figured I'd ask :)

Thanks for all the work you put into it!

— Reply to this email directly, view it on GitHub https://github.com/dokeraj/AndroTainer/issues/42#issuecomment-1065940218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIMHOT5FRGD463EUYYJQ5DU7TRBBANCNFSM5QPZ3MWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

dokeraj avatar Mar 12 '22 18:03 dokeraj

You won't get far with that one. It's one I set up myself and the image to it is private.

I noticed the same problem with "mmgoodnow/cross-seed", so maybe that one will help.

Byter09 avatar Mar 12 '22 19:03 Byter09

Thank you for the pointer. I will let you know once I find a solution to this.

On Sat, Mar 12, 2022, 20:00 Kevin Becker @.***> wrote:

You won't get far with that one. It's one I set up myself and the image to it is private.

I noticed the same problem with "mmgoodnow/cross-seed", so maybe that one will help.

— Reply to this email directly, view it on GitHub https://github.com/dokeraj/AndroTainer/issues/42#issuecomment-1065943525, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIMHOVUTID5FEQNVOOY27DU7TSVPANCNFSM5QPZ3MWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

dokeraj avatar Mar 12 '22 19:03 dokeraj

@Byter09 I've push a new version on Play Store, can you check to see if the issue has been resolved

dokeraj avatar Mar 13 '22 11:03 dokeraj

Works perfectly!

Byter09 avatar Mar 13 '22 15:03 Byter09