Vaibhav Gupta

Results 28 comments of Vaibhav Gupta

@ericholscher I have updated the minified files. I think we can upload it to pypi after this PR.

@ericholscher Nothing here. I will make all the PRs ready to be merged in master so that they can go out this week.

I will fix the conflicts and make this mergeable after merging of #42

@davidfischer I have updated the PR to not include the private methods. but I'm not sure what should be the correct approach for your comment [above](https://github.com/readthedocs/readthedocs-sphinx-search/pull/38#issuecomment-515595016). Do you have anything...

@erikdubbelboer I would like to start contributing to this. From the above discussion, it seems that we can mark the `Body()` function as deprecated but it is getting used at...

@erikdubbelboer We'll have to inject the Server.Logger instance in the request, right? Currently, there's no logger that I can fine in the req.

I am working on it. Will submit a PR soon.

It is still valid. There's an open PR for this.

This is still valid bot. Can I get a review on the attached PR?