dojo icon indicating copy to clipboard operation
dojo copied to clipboard

Event fields as key

Open remybar opened this issue 6 months ago • 6 comments

Closes #2228.

Depends on https://github.com/dojoengine/dojo-core/pull/12.

TODO: dojo-core should be removed as it has been moved to dojo-core repo.

Tests

  • [X] Yes
  • [ ] No, because they aren't needed
  • [ ] No, because I need help

Added to documentation?

  • [ ] README.md
  • [ ] Dojo Book
  • [X] No documentation needed

Checklist

  • [X] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • [X] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • [X] I've commented my code
  • [X] I've requested a review after addressing the comments

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced event handling in the smart contract framework by marking key fields for several event structures, improving clarity and efficiency in event processing.
    • Introduced a unified Event enum for streamlined event handling in tests, enhancing type safety and modularity.
    • Updated data structure in the event processing functions for improved performance and clarity.
  • Bug Fixes

    • Improved testing accuracy and reliability for various functionalities by ensuring proper ownership handling and enhancing event log assertions.
  • Chores

    • Updated configuration files with new addresses and class hashes, reflecting changes in the deployment environment.

remybar avatar Aug 09 '24 14:08 remybar