dojo icon indicating copy to clipboard operation
dojo copied to clipboard

[sozo] `sozo build --stats` Bytecode size displayed

Open notV4l opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Bytecode size displayed by sozo build --stats is sierra bytecode size https://github.com/dojoengine/dojo/blob/6dca9446b3894422b559dd86a43cf53abbe723ae/crates/sozo/ops/src/statistics.rs#L24

MAX_BYTECODE_SIZE limitation is related to casm bytecode size https://github.com/dojoengine/dojo/blob/6dca9446b3894422b559dd86a43cf53abbe723ae/crates/dojo-world/src/migration/mod.rs#L35 https://github.com/dojoengine/dojo/blob/6dca9446b3894422b559dd86a43cf53abbe723ae/crates/katana/primitives/src/utils/class.rs#L32

Describe the solution you'd like Display casm bytecode size as well

Also sort the contracts alphabetically

notV4l avatar May 13 '24 13:05 notV4l

Although a Go background, I can experiment on this?

fishonamos avatar May 13 '24 17:05 fishonamos

@fishonamos we need to also make some other changes along with this, so it will be a non-trivial issue. i will take this up.

itzlambda avatar May 14 '24 18:05 itzlambda

No problem. I am available for others issues if open. Just tag me.

fishonamos avatar May 14 '24 18:05 fishonamos