dojo icon indicating copy to clipboard operation
dojo copied to clipboard

Better testing for gRPC

Open broody opened this issue 1 year ago • 10 comments

Currently, there isn't very good coverage for gRPC. Would be great to have tests that covers all queries and subscriptions.

broody avatar Feb 20 '24 20:02 broody

I would like to work on this as well =)

gianalarcon avatar Feb 20 '24 21:02 gianalarcon

@gianalarcon how are you doing? Is this something you still want to tackle? We've to setup a whole test suite for gRPC automated testing. @lambda-0x should take over on some part of Torii, but if you've already started something let's sync on that! 👍

glihm avatar Jun 19 '24 21:06 glihm

All yours @glihm @lambda-0x . I would like to contribute in upcoming issues related to torii(graphql, grpc).

gianalarcon avatar Jun 20 '24 01:06 gianalarcon

@broody Can I work on this?

PedroRosalba avatar Jun 26 '24 15:06 PedroRosalba

@broody Can I work on this?

Ah I've been out of the loop, I think @lambda-0x is taking over this, but deferring to @glihm sensei

broody avatar Jun 26 '24 19:06 broody

hello @broody can i also hop on this

Supa-mega avatar Aug 20 '24 13:08 Supa-mega

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I've work with grpc a couple of times in the past. For UT usually what I do is creating a local grpc for listening the requests and I'd return some mocked data in order to increase coverage and make the code falls to the scenarios I want to test.

Kelvin01 avatar Aug 27 '24 15:08 Kelvin01

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a frontend and a blockchain developer. I will love to work on this

CollinsC1O avatar Sep 02 '24 15:09 CollinsC1O

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I’m a Computer Engineering student and a web developer with a growing interest in blockchain. I’ve recently started contributing to open source and am passionate about projects that encourage innovation and collaboration. My background in Computer Engineering and my focus on learning new technologies, including gRPC, aligns well with this issue. While I’m relatively new to open source, I’m eager to apply my skills, gain practical experience with gRPC, and contribute meaningfully to this project

How I plan on tackling this issue

Plan for Tackling the Issue:

Familiarize myself with the existing codebase and testing framework: I will review the current implementation of gRPC queries and subscriptions to understand the current test coverage and where gaps exist. Identify all gRPC queries and subscriptions: I’ll document all the queries and subscriptions that need coverage, ensuring that none are missed. Write comprehensive tests: Using this list, I will write unit tests and integration tests to ensure that all gRPC queries and subscriptions are properly tested. Ensure scalability: I will focus on writing tests that not only validate functionality but also handle edge cases and scalability concerns. Submit a PR for review: Once the tests are written, I will submit a pull request for feedback and refinement. Looking forward to contributing and helping improve the test coverage for gRPC!

llamitaOnfire avatar Sep 12 '24 17:09 llamitaOnfire

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have good knowledge using RPC from back end developing

jcampos2907 avatar Sep 20 '24 22:09 jcampos2907

I’m interested in this one.

GradleD avatar Nov 09 '24 05:11 GradleD

I’d love to work on this task.

Richiejosh avatar Nov 12 '24 11:11 Richiejosh

I'd like to take this issue.

teskpicoin avatar Nov 14 '24 08:11 teskpicoin

May I take care of this?

Samibhr09 avatar Dec 02 '24 21:12 Samibhr09

Sorry for the delay on this one guys. Removing the good first issue from now since there are some internal changes on-going. Will update here in the future based on the rework. 👍

glihm avatar Dec 02 '24 21:12 glihm