util icon indicating copy to clipboard operation
util copied to clipboard

building dojo project no longer generates output files after update to 1.17

Open rhpijnacker-philips opened this issue 2 years ago • 4 comments

In our product, we use the dojo build to deploy a number of layers, which are optimized using the closure compiler. After updating to 1.17 we find that, while it does produce the .consoleStripped.js and .uncompressed.js output files, the actually optimized files are no longer generated.

Please note that we already (locally) upgraded the closureCompiler to version 20210601 to allow us to use the newer style JavaScript syntax. Just swapping the 1.17.3 version with this older version fixes the problem of the generated output files.

rhpijnacker-philips avatar May 24 '23 11:05 rhpijnacker-philips

1.17.3 includes Closure Compiler v20220601. (PR) Any errors in the console or build-report.txt? Are you setting optimizeOptions in your profile?

dasa avatar May 24 '23 17:05 dasa

There are no errors, and no more warnings than with the older version of the compiler.

Process finished normally
	errors: 0
	warnings: 415
	build time: 52.934 seconds

The only options that we specify are to target a newer JavaScript version:

    optimizeOptions: {
      languageIn: 'ECMASCRIPT_NEXT',
      languageOut: 'ECMASCRIPT_2020'
    },

This was the reason for us to update to 20210601 back in the day.

rhpijnacker-philips avatar May 25 '23 05:05 rhpijnacker-philips

I don't always trust that summary. I find there can still be errors in the output or build-report.txt file.

dasa avatar May 25 '23 17:05 dasa

Neither do I, I just copied the summary as "proof".

rhpijnacker-philips avatar May 26 '23 06:05 rhpijnacker-philips