dxvk icon indicating copy to clipboard operation
dxvk copied to clipboard

meson: Check for bundled Vulkan/SPIR-V headers

Open flibitijibibo opened this issue 1 year ago • 3 comments

This is at least enough to use the system headers when building from the tarball, but doesn't check for any version requirements. While imperfect, it's an improvement on the current solution which is to sed -i meson.build, which is sort of overkill...

Partially fixes #3322

flibitijibibo avatar Feb 05 '24 00:02 flibitijibibo

There is no reason to ever use system headers for DXVK

misyltoad avatar Feb 05 '24 06:02 misyltoad

There is exactly one reason, and it's one only distributors care about: When building packages they have to use release tarballs, and GitHub still doesn't include the submodules. If dxvk had a custom archive for each release that mimics a recursive clone and trims out all the .git files, that would obsolete this change. (FNA does this, it's not too painful to automate)

flibitijibibo avatar Feb 05 '24 12:02 flibitijibibo

For completion's sake, this is the FNA "archivinate.sh" script:

#!/bin/bash

set -ex

cd "`dirname "$0"`"

git clone --recursive https://github.com/FNA-XNA/FNA
rm -rfv FNA/.git* FNA/lib/*/.git* FNA/lib/FNA3D/*/.git*

This could totally be made into a generic script by reading .gitmodules files recursively, but for projects that know their submodule tree a quick script like this does the job!

flibitijibibo avatar Feb 05 '24 14:02 flibitijibibo