dxvk icon indicating copy to clipboard operation
dxvk copied to clipboard

[dxgi] Implement support for more formats in GetMonitorFormatBpp

Open Etaash-mathamsetty opened this issue 2 years ago • 7 comments

Reduces log spam in 3dmark fire strike I don't know if it is any more useful than that lol

Etaash-mathamsetty avatar Apr 15 '23 16:04 Etaash-mathamsetty

What is Firestrike doing exactly? None of this should be necessary since we already handle all legal swap chain formats.

doitsujin avatar Apr 15 '23 18:04 doitsujin

Actually we're missing the RGB10A2 ones, but would still be good to know what the benchmark needs.

doitsujin avatar Apr 15 '23 18:04 doitsujin

What is Firestrike doing exactly? None of this should be necessary since we already handle all legal swap chain formats.

Not sure, it just seems to be calling this function for the hell of it, it doesn't change anything related to how it runs or performs

If you want me to do further testing (like with a API trace, just tell me)

Etaash-mathamsetty avatar Apr 15 '23 19:04 Etaash-mathamsetty

can you post a log?

doitsujin avatar Apr 15 '23 20:04 doitsujin

without patch: steam-231350.log

with patch: steam-231350.log

Etaash-mathamsetty avatar Apr 15 '23 22:04 Etaash-mathamsetty

@doitsujin I posted the logs, could you look at them?

Etaash-mathamsetty avatar May 01 '23 20:05 Etaash-mathamsetty

I did look at them, for some reason it's querying everything somehow. Need to think about a more elegant way to improve this.

doitsujin avatar May 03 '23 13:05 doitsujin