dxvk icon indicating copy to clipboard operation
dxvk copied to clipboard

Release 2.0: missing files in source code archive (.zip/.tar.gz)

Open tjkl1 opened this issue 3 years ago • 1 comments

While building dxvk 2.0, files below ./include/{spirv,vulkan} are expected. Yet the files from the submodules are missing in the archive, thus dxvk cannot be build from the archives:

[ 6s] C++ linker for the build machine: c++ ld.bfd 2.39.0.20220810-1 [ 6s] Build machine cpu family: x86_64 [ 6s] Build machine cpu: x86_64 [ 6s] Host machine cpu family: x86_64 [ 6s] Host machine cpu: x86_64 [ 6s] Target machine cpu family: x86_64 [ 6s] Target machine cpu: x86_64 [ 6s] Library d3d9 found: YES [ 6s] Library d3d11 found: YES [ 6s] Library dxgi found: YES [ 6s] Library d3dcompiler_47 found: YES [ 6s] Program x86_64-w64-mingw32-windres found: YES [ 6s] [ 6s] meson.build:124:0: ERROR: Include dir ./include/vulkan/include does not exist.

tjkl1 avatar Nov 11 '22 13:11 tjkl1

Those archives are generated by github.

DadSchoorse avatar Nov 11 '22 15:11 DadSchoorse

Yeah, doesn't look like there's anything we can do about that.

Apparently people have been complaining about that for almost 7 years at this point.

doitsujin avatar Nov 11 '22 18:11 doitsujin

Worked up until this release, but i didn't check if those folders were in submodules before 2.0 or not.

tjkl1 avatar Nov 11 '22 23:11 tjkl1

DXVK didn't use submodules before 2.0.

K0bin avatar Nov 12 '22 00:11 K0bin

I really don't think this bug report has anything to do with what github may or may not do. The more general question is "maybe the project should provide release tarballs".

It's very easy to do that, you can just run meson dist --no-tests and upload the resulting meson-dist/*.tar.xz file. This will include submodules.

eli-schwartz avatar Nov 13 '22 20:11 eli-schwartz

So, how to fix that?

ILoveAlgorythms avatar Sep 21 '23 21:09 ILoveAlgorythms

Clone the repo and run git submodule update --init --recursive

K0bin avatar Sep 22 '23 00:09 K0bin