kube-no-trouble icon indicating copy to clipboard operation
kube-no-trouble copied to clipboard

Published 20 hours ago • verified publisher icon doitintl

feat: Add handling simple resource groups

Open Jmspz opened this issue 2 years ago • 1 comments

feat: Add handling simple resource groups when adding additional kinds to scan

If the API version is not included in the code for resources in groups apps, batch, autoscaling, etc, add the ability to scan for those resources using the -a option.

Jmspz avatar Aug 03 '22 22:08 Jmspz

I like this. Would like to see readme and docs updated however.

dark0dave avatar Sep 01 '22 12:09 dark0dave

@dark0dave this PR is not adding a flag, just fixing validation for the existing one.

@Jmspz thank you for this 👍

Can you please add an example here with what's currently not handled, and would be with this fix in place?

Internally we're using ParseKindArg ^1 so can that function handle this shorter form? I'm not 100% by the description, might need to be tested.

For sure we should add some tests for this.

stepanstipl avatar Dec 15 '22 10:12 stepanstipl

Closing as I haven't heard back. I don't see this as desirable, see more in #414.

stepanstipl avatar Feb 07 '23 16:02 stepanstipl