Dominic Garms comments

Results 180 comments of


Dominic Garms

componentUpdater.ts uses propTypesMap instead of Component.propTypes

any chance this getting merged?

Use split bundle to reduce dependency requirements

> Also, when copying the files I get the following bundlesize increase (expected): > > [graphcommerce-org/graphcommerce#1579 (comment)](https://github.com/graphcommerce-org/graphcommerce/pull/1579#issuecomment-1239788897) > > When using the library as is (with the missing dependencies installed)...

Use split bundle to reduce dependency requirements

I'm closing the issue seems to be working as expected.

Enable specifying the required message for "SliderElement" component

I think this is a great candidate for the v7. I wanted to do that already but didn't want to introduce breaking changes. v7 would be a great fit to...

Enable specifying the required message for "SliderElement" component

fixed in v7.0.0-beta.2

dont bundle everything in one file / should not require @mui/x-date-pickers unless used

add the peerDependencies, they will be stripped out of your bundler ```ts # yarn add @mui/x-date-pickers @mui/icons-material ```

dont bundle everything in one file / should not require @mui/x-date-pickers unless used

is that really a concern nowadays? Isn't everyone using modern tools like Vite or NextJS which have very fast startup times? We could have a look for v7 if it...

dont bundle everything in one file / should not require @mui/x-date-pickers unless used

closing in favour of #252

Support webP transform with the image proxy transform API

I guess the best would be something like a `?o=1` (optimise=true) and based on the supported request header the image proxy would return WebP, AVIF or any other image format...

Support webP transform with the image proxy transform API

@jovermier yes I think any path, either `o`=>optimise or `c`=>compress would convert the image in following order: AVIF, WebP or no manipulation based on `Accept` header. I would assume that...