[bug] tx confirmation window is getting out of the screen and can't click on "send"

[Decryptu]

Bug Report

Current behavior:

When writing too much text in the "label" field on Dogecoin Core, the confirmation window is getting out of the screen and it is impossible to move it, resize it, scroll the text, to access the "send" button, no keyboard shortcut is working either.

Expected behavior

Steps to reproduce:

Write a lot of text in the "label" field

Screenshots

Dogecoin Core version

Dogecoin Core version v1.14.6.0-3a29ba6d4 (64-bit)

Machine specs

• OS: macOS Ventura 13.0
• CPU: Silicon M1
• RAM: 16 GB
• Disk size: 512 GB
• Disk Type (HD/SDD): SSD

Extra information

[patricklodder]

Was able to fully reproduce this, on both M1 and Intel macOS.

In the address book, the display is limited based on text size fitting within allocated pixels, but maybe we can for starters limit the size of the displayed label in this modal to a fixed number of characters. This is a good first issue for new contributors.

I'd propose a maximum of 45 characters to not wrap lines in the label and be able to add ... if the size exceeds that:

Code location: https://github.com/dogecoin/dogecoin/blob/3a29ba6d497cd1d0a32ecb039da0d35ea43c9c85/src/qt/sendcoinsdialog.cpp#L277-L281

[evil-user]

@patricklodder @Decryptu is this issue specific for mac os ?

[patricklodder]

No, but on macOS it is impossible to get past it. On other OS' this should be easier to handle.

[evil-user]

@patricklodder is there any way i can reproduce this issue in a simple way without owning dogecoin ( other than manually inspecting code and changing values which would take time as i am new to codebase )

[patricklodder]

is there any way i can reproduce this issue in a simple way without owning dogecoin

Yes (almost-ish)!

1. Run a testnet node instead of a mainnet node by starting with dogecoin-qt -testnet (logo should turn green)
2. Let it sync (should take <2h on average) - it's always good to have a sync'd testnet node when dealing with UI problems.
3. Get a new address from "much receive" (will start with an n instead of a D)
4. Get some DOGE off the testnet faucet or if that for any reason doesn't work, just ask here - a lot of people here have testdoge
5. Simulate the issue :-)

[Anish-M-code]

@patricklodder I have attempted to fix this issue by setting maximum of 45 characters to not wrap lines in the label and be able to add ... if the size exceeds that as you have mentioned.

[patricklodder]

I have attempted to fix this issue by setting maximum of 45 characters to not wrap lines in the label and be able to add ... if the size exceeds that as you have mentioned.

Thank you! I've put your pull request in the review queue with priority because it's a bug fix.

[patricklodder]

Fixed with #3224