Myungchul Keum

Results 30 comments of Myungchul Keum

Duplicate of Issue #853, #857 Anyway, I think next version should be 1.4.11 or 1.4.11.0, to avoid confusion with version sorting.

Build shared and static library saperately. Something like ``` # Build shared mkdir build-shared && cd build-shared cmake .. -DENABLE_SHARED=1 -DENABLE_STATIC=0 make # Build static mkdir build-static && cd build-static...

PNG_SUPPORTED flag is not used in sharedlib/CMakeLists.txt at all. So only static version of mozjpeg supportes PNG. Use *-static for PNG support for now.

I think this PR closed accidentally and should be opened again.

@lmoellendorf The segfault problem at #125 was fixed with later PR #146(merged). What this PR is different from #146 is, `iniparser_getstring()` won't return `NULL` even if the value is `NULL`(caused...

@lmoellendorf Please reconsider merging this PR. Even authors of iniparser missed the null check and made CVE entry ([CVE-2023-33461](https://github.com/advisories/GHSA-j5q7-9p99-x3r2)). #125 #144 Users are more likely to miss that too. 😧...

Returning "(null)" is not so wrong. With common compilers (including gcc, msvc), ``` printf("%s", NULL); ``` prints `(null)` instead of crashing entire program. (Its behavior is undefined in C standard)...

Future plan: Change build system using [nanobind](https://github.com/wjakob/nanobind)(based on CMake). As nanobind does not support Python 3.7, this won't be done near future. → ~~After a stable python-soxr release for Python...

@kornelski Please update `auth_token` in appveyor.yml. Is there something that blocks token update?