dodola
OKEY > @dodolalorc please sign your commit and rebase!
> It looks like some commits are still not signed. Would you be able to sign them? :) I've try rebase all my commits. What about now? :) sorry for...
> @dodolalorc Electron's CI was having issues building your changes, which is now resolved by #48319. Would you mind rebasing your branch one more time to the latest changes on...
@nikwen The warning from the bot should be due to a wrong operation I made midway when signing the commit before. Later, I used force push to overwrite that wrong...
> @dodolalorc Agree that that's what was going on. (I later updated my comment above, but it probably didn't send you a notification for that.) > > I've pinged our...
@jkleinsc I've applied your feedback. Thanks for your suggestion!
@samuelmaddock please trigger the ci again. Thank you!
> We're seeing crashes in CI: > > ``` > [1716:0928/183528.604:ERROR:third_party\blink\renderer\core\html\media\html_media_element.cc:5045] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Format error"} > [9080:0928/183528.604:FATAL:base\task\sequence_manager\thread_controller.cc:653] DCHECK failed: !delta.is_negative(). -0.000605 s > Symbols not available. Dumping unresolved backtrace:...