node-unicodetable icon indicating copy to clipboard operation
node-unicodetable copied to clipboard

Added missing proxy fields

Open nwinkler opened this issue 10 years ago • 6 comments

When using http.get() to request a file through a proxy, the following were missing from the previous implementation:

  • The http:// protocol
  • The headers object indicating the target Host

These additions are based on http://stackoverflow.com/a/6781592/1228454 and work for our company proxy (MS NTLM Proxy).

The previous implementation always silently failed, it simply exited the process right after the fetching ... message.

nwinkler avatar Nov 12 '15 13:11 nwinkler

Worked for me too :+1:

euphocat avatar Mar 16 '16 13:03 euphocat

@dodo this would then resolve many issues on dependant projects: dodo/node-slug#58 keystonejs/generator-keystone#129

the symptom I'm seeing is Error: Cannot find module 'unicode/category/So'.

...The proxy server sends back a page saying "Sorry, I don't know how to get to that URL without a protocol" and this library tries to parse the error page as if it was UnicodeData.txt, so you end up with undefined.js and font-family: Tahoma, Roya, sans-serif.js in the category directory.

nalbion avatar Aug 26 '16 07:08 nalbion

Does this needs any more work before merging?

nimser avatar Dec 01 '16 16:12 nimser

This would also fix an issue I'm seeing on Circle CI:

  • https://discuss.circleci.com/t/node-cannot-find-module-unicode-category-so/8990

😄

dylanjha avatar Dec 20 '16 22:12 dylanjha

Hi there, any news on this? This issue is pretty annoying... :)

nicooprat avatar Feb 22 '17 08:02 nicooprat

+1 on this, it is a very annoying issue causing our travis-ci builds to fail.

SamuelBolduc avatar Feb 28 '17 22:02 SamuelBolduc