dodexahedron

Results 412 comments of dodexahedron

While diving down the CursesDriver rabbit hole to address other issues (#3287 covers some of it), I'm now rapidly leaning toward and half talking myself into going ahead and tackling...

> When we don't need pinvokes for Windows, they may not be necessary for Linux/Mac either. Everything is interconnected with completely different systems and only by handling them is it...

> Curses (and noncurses) are not magic. > > They do what we already partially do, and need to do fully on Windows (to support VTS) anyway. > > We...

(Side note: That's another good place for a project, to organize all related work, since it's not a small endeavor.)

General future commentary based on this: An analyzer would be helpful for these situations, to catch them at design-time, in-context. Not worth it if they're super-temporary, though, usually, of course....

Rectangle already has that functionality built-in, no?

Cache locality is important to maintain for something like this. Be sure to allocate the arrays from `Memory` and use the pool to avoid excessive heap activity and fragmentation.

If using HashSet, then just using the ArrayPool is fine. Be sure to over-allocate up front to avoid re-allocation. Rectangles are cheap (16 bytes). Example, whenever the HashSet is initially...

But also, note that duplicates are really cheap and likely to cost less than advantages you can gain by being able to operate over Spans and slices of Memory and...

Another thought: Any time you have to enumerate the entire set, copy it to a span first and enumerate that. It makes a HUGE difference.