docusign-esign-csharp-client icon indicating copy to clipboard operation
docusign-esign-csharp-client copied to clipboard

Fix setting BasePath and OAuthBasePath in DocuSignClient ctors

Open gagyn opened this issue 2 years ago • 1 comments

I lost 2 hours investigating why I'm getting USER_AUTHENTICATION_FAILED response. It was happening, because SDK was calling production API, instead of demo, even after providing BaseUrl for Demo to DocuSignClient constructor. 😐

Current version of DocuSign SDK contains bug causing wrong assignment of BasePath while initializing DocuSignClient object. Current workaround is to set api base path using SetBasePath(basePath), but it should be done by constructor, when using overload: public DocuSignClient(string apiBase, string oAuthBase, IWebProxy proxy = null) (line 155).

Also Configuration = new Configuration(apiBase); is useless in every constructor as SetBasePath method always calls it anyway but haven't touched it.

gagyn avatar Oct 07 '22 17:10 gagyn

AppVeyor build and test pass.

AppVeyorBot avatar Oct 07 '22 17:10 AppVeyorBot

It would appear that these changes were made as part of v6.1.0. See here in the commit.

voltaek avatar Jan 17 '23 20:01 voltaek

Correct, these changes have been incorporated into a recent release. Closing the PR.

kenharris avatar Apr 12 '23 21:04 kenharris