community
community copied to clipboard
Remove deprecated style keyword
Fixes: https://github.com/kivy/kivy/issues/8230
Style keyword is deprecated in sphinx 7.x
Maintainer merge checklist
- [ ] Title is descriptive/clear for inclusion in release notes.
- [ ] Applied a
Component: xxx
label. - [ ] Applied the
api-deprecation
orapi-break
label. - [ ] Applied the
release-highlight
label to be highlighted in release notes. - [ ] Added to the milestone version it was merged into.
- [ ] Unittests are included in PR.
- [ ] Properly documented, including
versionadded
,versionchanged
as needed.
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.
Hi @misl6
Thank you for a quick reply.
So my thinking was to install sphinx version 7.x and try to build kivy documentation with a simple make target.
make html
or make -C doc html
This is the minimal fix that makes the docs to build.
Perhaps i am missing something else. Please direct me. Thanks!
So my thinking was to install sphinx version 7.x and try to build kivy documentation with a simple make target. Yep, that build is also performed by our CI/CD pipeline, and we can configure to do that with sphinx 7.x.x.
Did you checked https://github.com/sphinx-doc/sphinx/pull/11381/files ? It looks like to me we actually need to support more stylesheets, and definitely we do not need to change style
to styles
in this HTML tag.
@misl6 Indeed, thank you. Please take a look at the latest change. This builds in the latest sphinx and leaves the HTML tag alone.
Fixed a typo.
Congrats on merging your first pull request! 🎉🎉🎉