community icon indicating copy to clipboard operation
community copied to clipboard

Remove deprecated style keyword

Open kbaikov opened this issue 10 months ago • 5 comments

Fixes: https://github.com/kivy/kivy/issues/8230

Style keyword is deprecated in sphinx 7.x

Maintainer merge checklist

  • [ ] Title is descriptive/clear for inclusion in release notes.
  • [ ] Applied a Component: xxx label.
  • [ ] Applied the api-deprecation or api-break label.
  • [ ] Applied the release-highlight label to be highlighted in release notes.
  • [ ] Added to the milestone version it was merged into.
  • [ ] Unittests are included in PR.
  • [ ] Properly documented, including versionadded, versionchanged as needed.

kbaikov avatar Apr 28 '24 22:04 kbaikov

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

welcome[bot] avatar Apr 28 '24 22:04 welcome[bot]

Hi @misl6

Thank you for a quick reply. So my thinking was to install sphinx version 7.x and try to build kivy documentation with a simple make target. make html or make -C doc html This is the minimal fix that makes the docs to build.

Perhaps i am missing something else. Please direct me. Thanks!

kbaikov avatar Apr 30 '24 19:04 kbaikov

So my thinking was to install sphinx version 7.x and try to build kivy documentation with a simple make target. Yep, that build is also performed by our CI/CD pipeline, and we can configure to do that with sphinx 7.x.x.

Did you checked https://github.com/sphinx-doc/sphinx/pull/11381/files ? It looks like to me we actually need to support more stylesheets, and definitely we do not need to change style to styles in this HTML tag.

misl6 avatar May 01 '24 08:05 misl6

@misl6 Indeed, thank you. Please take a look at the latest change. This builds in the latest sphinx and leaves the HTML tag alone.

kbaikov avatar May 02 '24 11:05 kbaikov

Fixed a typo.

kbaikov avatar May 02 '24 18:05 kbaikov

Congrats on merging your first pull request! 🎉🎉🎉

welcome[bot] avatar May 04 '24 08:05 welcome[bot]