community icon indicating copy to clipboard operation
community copied to clipboard

Remove all the PY2 compat code

Open Valinor opened this issue 1 year ago โ€ข 2 comments
trafficstars

See #8566

  • [X] Title is descriptive/clear for inclusion in release notes.
  • [ ] Applied a Component: xxx label.
  • [ ] Applied the api-deprecation or api-break label.
  • [ ] Applied the release-highlight label to be highlighted in release notes.
  • [ ] Added to the milestone version it was merged into.
  • [ ] Unittests are included in PR.
  • [ ] Properly documented, including versionadded, versionchanged as needed.

Valinor avatar Feb 11 '24 20:02 Valinor

Thanks for opening your first pull request here! ๐Ÿ’– Please check out our contributing guidelines.

welcome[bot] avatar Feb 11 '24 20:02 welcome[bot]

Hi @Valinor !

I've left some minor suggestions.

Nice work and cleanup ๐Ÿงน BTW!

Thanks for the review. Shame on me to let pass all of these :').

I will try to understand why some tests fails on the ci, and not for me, and take care of your suggestions.

Valinor avatar Feb 15 '24 07:02 Valinor

I will try to understand why some tests fails on the ci

When you push changes, make sure to rebase on top of latest master, as the CI errors you seen might be related to https://github.com/kivy/kivy/pull/8618 (so, not your fault)

misl6 avatar Feb 17 '24 14:02 misl6

@Valinor FYI:

We also may want to do some cleanup here: https://github.com/kivy/kivy/blob/dc7fd3d8ae28029ebecfbb923af37caa4a5245c9/kivy/uix/screenmanager.py#L1090

misl6 avatar Feb 22 '24 17:02 misl6

Hi @Valinor,

This is a friendly ping, are you still active on this PR?

misl6 avatar Mar 02 '24 08:03 misl6

@Valinor FYI: I've performed some changes to your PR due to inactivity, thank you for doing most of the work BTW!

misl6 avatar Mar 23 '24 16:03 misl6

Congrats on merging your first pull request! ๐ŸŽ‰๐ŸŽ‰๐ŸŽ‰

welcome[bot] avatar Mar 23 '24 16:03 welcome[bot]

@Valinor FYI: I've performed some changes to your PR due to inactivity, thank you for doing most of the work BTW!

Thanks, and sorry for my inactivity. I will try to be more productive next time. Great change, thanks for your work.

Valinor avatar Mar 23 '24 16:03 Valinor