community icon indicating copy to clipboard operation
community copied to clipboard

Handling of write_tab, checking if self.write_tab is False before deciding how to handle the tab key.

Open jhonatancaetano opened this issue 2 years ago • 3 comments
trafficstars

Addressing #8107

Maintainer merge checklist

  • [X] Title is descriptive/clear for inclusion in release notes.
  • [ ] Applied a Component: xxx label.
  • [ ] Applied the api-deprecation or api-break label.
  • [ ] Applied the release-highlight label to be highlighted in release notes.
  • [ ] Added to the milestone version it was merged into.
  • [ ] Unittests are included in PR.
  • [ ] Properly documented, including versionadded, versionchanged as needed.

This modified version of the keyboard_on_key_down method checks if self.write_tab is False before deciding how to handle the "tab" key. If self.write_tab is False, it manually inserts a tab character ('\t') into the text input. Otherwise, it continues with the original behavior where the "tab" key moves the focus to the next widget.

jhonatancaetano avatar May 31 '23 00:05 jhonatancaetano

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

welcome[bot] avatar May 31 '23 00:05 welcome[bot]

Hey @misl6! How are you doing? If you have some spare time, would you mind reviewing this PR? Thanks in advance!

jhonatancaetano avatar Jun 20 '23 19:06 jhonatancaetano

The write_tab is checked before hand in keyboard_key_down. Do you have a issue that this is solving ?

akshayaurora avatar Jun 21 '23 08:06 akshayaurora