community
community copied to clipboard
Handling of write_tab, checking if self.write_tab is False before deciding how to handle the tab key.
Addressing #8107
Maintainer merge checklist
- [X] Title is descriptive/clear for inclusion in release notes.
- [ ] Applied a
Component: xxxlabel. - [ ] Applied the
api-deprecationorapi-breaklabel. - [ ] Applied the
release-highlightlabel to be highlighted in release notes. - [ ] Added to the milestone version it was merged into.
- [ ] Unittests are included in PR.
- [ ] Properly documented, including
versionadded,versionchangedas needed.
This modified version of the keyboard_on_key_down method checks if self.write_tab is False before deciding how to handle the "tab" key. If self.write_tab is False, it manually inserts a tab character ('\t') into the text input. Otherwise, it continues with the original behavior where the "tab" key moves the focus to the next widget.
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.
Hey @misl6! How are you doing? If you have some spare time, would you mind reviewing this PR? Thanks in advance!
The write_tab is checked before hand in keyboard_key_down. Do you have a issue that this is solving ?