community icon indicating copy to clipboard operation
community copied to clipboard

Enable SDL2 ios keyboard selection

Open GoBig87 opened this issue 5 years ago • 5 comments

This allows ios developers the ability to change keyboard types

GoBig87 avatar Oct 06 '20 03:10 GoBig87

https://github.com/kivy/kivy/pull/7231 does something related for android.

matham avatar Dec 30 '20 00:12 matham

@matham @GoBig87 that's a nice feature, but before reviewing it, We should make a decision on how to handle this kind of feature that needs patching on a third-party library.

What I'm concerned about it's that We (potentially) need to re-build the patch every time a specific recipe needs to be updated. It's ok for fixing cross-compiling issues but seems a potential headache when We should do that in order to support features that could be merged on the third-party library upstream.

How about asking for a merge into the SDL upstream? Obviously couldn't be merged as-is and should be improved (in order to make it backward-compatible), but shouldn't be too hard.

misl6 avatar Dec 30 '20 19:12 misl6

@misl6 I'm a little confused about your comment. Because this PR has no patches. Were you talking about the android PR?

But I'm wondering if this PR is fine?

matham avatar Dec 30 '20 21:12 matham

@matham

This PR itself doesn't work (and shouldn't me merged) until We merge https://github.com/kivy/kivy-ios/pull/559 on kivy-ios.

The kivy-ios related PR provides the needed edits to the SDL_StartTextInput.

(Basically the two PRs complete each other, and if one of the two PRs doesn't get merged We have a broken upstream for kivy or kivy-ios)

misl6 avatar Dec 30 '20 22:12 misl6

Ok, thanks for clarifying. I missed that context. I put it on hold until the kivy-ios side is worked out.

matham avatar Dec 30 '20 22:12 matham