community
community copied to clipboard
Image Zoom
A simple zoom on an image and the scale of the image on a label
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.
So, if this is to go into the examples, it should ideally be a well documented, clear and concise piece of code. Keep in mind, people are going to be looking at it trying to understand what it does and how.
To that end, I would suggest the following:
- Clear doc strings indicating what the purpose of the examples is, what is does and how to use it.
- Pep 8 fixes - there are many pep 8 violations in the code.
- More careful naming e.g. Line 145 starts a
MainAppclass, when it's not an app but aBoxLayout. - You might consider using kv to create to widget tree, as it would be more concise and readable?
- The zoom currently only seems to support mouse scrolling as zoom, not pinching or multi-touch. It might be nice to add this for mobile use cases?
Those are some suggestions. You are welcome to question some of them if you feel otherwise?
Thanks for the contribution +1. But we do need to ensure the example are of the highest quality. Hoping to hear back from you.
Regards