documenso
documenso copied to clipboard
Document Sharing Link Redirects to Homepage
Issue Description
Opening a sharing link to a document throws a console error and redirects to documenso.com (example my pledge: https://app.documenso.com/share/sdwlb8c7t1pkvu)
8593596e-8fa50b0cbb75b2d0.js:9 Uncaught Error: Minified React error #419; visit https://reactjs.org/docs/error-decoder.html?invariant=419 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at 8593596e-8fa50b0cbb75b2d0.js:9:63944
at Qh (8593596e-8fa50b0cbb75b2d0.js:9:64832)
at rx (8593596e-8fa50b0cbb75b2d0.js:9:120339)
at Lk (8593596e-8fa50b0cbb75b2d0.js:9:94328)
at 8593596e-8fa50b0cbb75b2d0.js:9:94150
at bf (8593596e-8fa50b0cbb75b2d0.js:9:94157)
at mf (8593596e-8fa50b0cbb75b2d0.js:9:90680)
at MessagePort.P (499-e5ab349bd0ad5c7b.js:25:1665)
(anonymous) @ 8593596e-8fa50b0cbb75b2d0.js:9
Qh @ 8593596e-8fa50b0cbb75b2d0.js:9
rx @ 8593596e-8fa50b0cbb75b2d0.js:9
Lk @ 8593596e-8fa50b0cbb75b2d0.js:9
(anonymous) @ 8593596e-8fa50b0cbb75b2d0.js:9
bf @ 8593596e-8fa50b0cbb75b2d0.js:9
mf @ 8593596e-8fa50b0cbb75b2d0.js:9
P @ 499-e5ab349bd0ad5c7b.js:25
Steps to Reproduce
- go to /documents
- Click the "share" button (wait for wayyy too long for it to be copied into clipboard)
- Paste into new (incognito) tab
- Get redirected to documenso.com
Expected Behavior
I expected to see my signed supporter pledge
Current Behavior
I am seeing the homepage
Screenshots (optional)
Environment
- OS: macOS Sonoma
- Browser: Chrome
- Version: 118
Checklist
- [x] I have searched the existing issues to make sure this is not a duplicate.
- [x] I have provided steps to reproduce the issue.
- [x] I have included relevant environment information.
- [x] I have included any relevant screenshots.
- [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I would like to pick this up
G'day, this one while not a bug does pose the question about phrasing.
Sharing is intended to be used for some minor virality, the intention is that people that have enjoyed the signing experience can share that by receiving a link that'll show that they've signed with Documenso with their signature or name displayed.
Problem is in the document dashboard this isn't inherently obvious:
One might assume that sharing could be used to invite a recipient to sign a document which isn't the case, to improve upon this we should use the same sharing dialog that we have elsewhere in the app:
One way to do this would be to allow the document share button to take in an optional children prop which will override the dialog trigger if provided.
@mittalsam98 If you're confident you can make these changes I'm happy to assign it to you 🙌
the "it" in the suggested tweet seems to refer to the document tho. Could that be rewritten too?
I just signed a document with @documenso. Check them out!
[url]
Oh and it could be referral link to maybe get one more free document this month.
@mittalsam98 If you're confident you can make these changes I'm happy to assign it to you 🙌
I will liked to look into this issue .
@mittalsam98 giving this to @luckyklyist apologies!
This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected