feat: signing order
https://github.com/user-attachments/assets/439ca3f0-150e-4685-858f-5f136bd7a5ac
Summary by CodeRabbit
-
New Features
- Introduced a signing order feature for document signing, allowing users to specify the order in which signers will receive documents.
- Added a new mutation for setting the signing order for documents.
- Enhanced document editing with the ability to manage signing order directly in the submission workflow.
- Implemented drag-and-drop functionality for reordering signers, updating their signing orders accordingly.
- Added new localization strings to support the signing order feature.
-
Bug Fixes
- Improved handling of recipient signing order to ensure that signing actions respect the specified order.
-
Documentation
- Updated localization strings to reflect new features and improve user experience.
-
Style
- Enhanced CSS variables for better customization of widget appearances in light and dark themes.
The latest updates on your projects. Learn more about Vercel for Git βοΈ
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| prd-app | π Building (Inspect) | Visit Preview | π¬ Add feedback | Sep 16, 2024 11:17am |
| prd-docs | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Sep 16, 2024 11:17am |
| prd-marketing | π Building (Inspect) | Visit Preview | π¬ Add feedback | Sep 16, 2024 11:17am |
| stg-app | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Sep 16, 2024 11:17am |
| stg-docs | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Sep 16, 2024 11:17am |
| stg-marketing | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Sep 16, 2024 11:17am |
Walkthrough
The changes involve the introduction of comprehensive coding guidelines for TypeScript development, focusing on functional programming, modularity, and error handling. Enhancements are made to the document signing workflow, particularly regarding managing signing orders, updating localization strings, and refining error handling practices across multiple files to ensure a cohesive user experience.
Changes
| Files | Change Summary |
|---|---|
.cursorrules |
Added coding guidelines and best practices for TypeScript development, emphasizing functional programming, modularity, and error handling. |
apps/web/src/middleware.ts |
Changed quotation marks in the Content-Security-Policy header from double to single quotes. |
packages/lib/translations/de/common.po, packages/lib/translations/en/common.po |
Updated line numbers for existing translation entries and added a new entry for "Enable signing order." |
packages/lib/translations/de/web.po, packages/lib/translations/en/web.po |
Adjusted line numbers for various message identifiers to reflect changes in the source code structure. |
packages/ui/primitives/document-flow/add-signers.tsx |
Enhanced the AddSignersFormPartial component with a signing order feature, allowing users to specify the order of signers and introducing drag-and-drop functionality for reordering. |
Possibly related PRs
- #1101: Introduces coding guidelines for TypeScript development, which may relate to the documentation site changes emphasizing clarity and organization.
- #1139: This PR focuses on ensuring that all required signature fields are present before proceeding, which aligns with the main PR's emphasis on error handling and validation best practices.
- #1141: The addition of advanced field types and validation in this PR complements the main PR's focus on coding guidelines and best practices for TypeScript, particularly in the context of form validation.
- #1180: The introduction of public profiles may relate to the main PR's emphasis on user-friendly error messages and validation, as public profiles could require similar considerations for user input and feedback.
- #1337: The language switcher feature enhances user experience, which aligns with the main PR's focus on user-friendly practices and error handling in the context of coding guidelines.
Suggested labels
pkg: ee changes
π° In a world of papers and ink,
I hop and dance, oh what a link!
With signing orders now in play,
Each signer knows their turn today!
Let's celebrate this joyful cheer,
For every hop brings signatures near! πβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
--
I pushed a fix in commit <commit_id>, please review it.--Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples: --@coderabbitai generate unit testing code for this file.--@coderabbitai modularize this function. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: --@coderabbitai generate interesting stats about this repository and render them as a table.--@coderabbitai read src/utils.ts and generate unit testing code.--@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.--@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@coderabbitai review
Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This is now ready to go but we need to deal with the failing tests. I'm assuming it'll be a symptom of our updated sorting logic throwing an error somewhere