flexie icon indicating copy to clipboard operation
flexie copied to clipboard

IE8 crash if using flexMatrix

Open daverodgman opened this issue 12 years ago • 0 comments

Using IE8 / flexie 1.0.3 / jquery 1.7.1 / selectivizr v1.0.2:

        var flexie = new Flexie.box({
            target: newElement[0],
            flexMatrix: this.options.use_flexie ? [0, 1, 0] : [0, 1],
        });

crashes at line 1551 because x.properties is null. Removing the flexMatrix argument fixes the crash.

The following seems to fix it. It does leave an overflow problem (the right hand column ends up on a new line when it should fill the current row), which might or might not be related to this fix:

--- a/Software/CurryWebContent/content/js/flexie.js +++ b/Software/CurryWebContent/content/js/flexie.js @@ -1547,6 +1547,7 @@ var Flexie = (function (win, doc) { for (k = 0, l = flexers[key].length; k < l; k++) { x = flexers[key][k]; max = NULL;

  •                                                   if (x.properties != null) {
                                                    for (m = 0, n = x.properties.length; m < n; m++) {
                                                            rule = x.properties[m];
    

@@ -1554,6 +1555,7 @@ var Flexie = (function (win, doc) { max = parseFloat(rule.value); } }

  •                                                   }
                                                    if (!max || x.match[self.props.out] > max) {
                                                            appendPixelValue(x.match, self.props.pos, NULL);
    

daverodgman avatar Jan 03 '12 16:01 daverodgman