phpcr-odm icon indicating copy to clipboard operation
phpcr-odm copied to clipboard

Bug with translations and early exit

Open dantleech opened this issue 10 years ago • 7 comments

Just for the record there seems to be a bug with the new early exist in the UOW#commit relating to updating translations, but not able to figure it out right now.

dantleech avatar Jun 15 '14 19:06 dantleech

you mean we overlook when there are only translations to update and no other changes?

dbu avatar Jun 16 '14 08:06 dbu

that would be something the orm does not do as its not aware of translations.

dbu avatar Jun 16 '14 08:06 dbu

is this fixed?

lsmith77 avatar Jul 21 '14 11:07 lsmith77

ping

lsmith77 avatar Aug 06 '14 14:08 lsmith77

would be great to have a test case for this situation, whether its currently broken or not.

dbu avatar Aug 06 '14 15:08 dbu

We should probably be more strict about merging things without test-cases. I submitted that fix quite a while back :)

dantleech avatar Aug 09 '14 17:08 dantleech

agreed. was there a test case i did not find? or can you do one?

dbu avatar Aug 10 '14 15:08 dbu