Fix eager fetch composite foreign key
I think https://github.com/doctrine/orm/pull/11289 did not completely fix problem for eager fetch. Change in that PR checked if primary key of target class is composite but that does not matter when loading collection by foreign key. It should check if foreign key on target class is composite.
Fix from that PR did not work for me because i had entity with regular autogenerated id (single column), but foreign key referenced entity with composite primary key, like SecondLevelWithoutCompositePrimaryKey in this PR.
Checking if foreign key is composite fixed the problem for me.
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
Need to look into this again
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
@beberlei can you take a look at PR?
Hello @greg0ire Sorry for ping. I’d really appreciate it if you could take a look when you have some time
I don't think I can be of much help here, sorry… that being said, it looks like your change breaks the build, so you should probably fix that so that the branch is clean next time Benjamin has time to look into it. Also, maybe @themash has opinions on this?
@greg0ire okay, thanks anyway 😃
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
Would be great if this got fixed since it's still an issue :slightly_smiling_face:
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
I'm still hoping this gets fixed :smile:
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
Still relevant.
Thanks @Brajk19 !