orm icon indicating copy to clipboard operation
orm copied to clipboard

Fix eager fetch composite foreign key

Open Brajk19 opened this issue 2 years ago • 7 comments

I think https://github.com/doctrine/orm/pull/11289 did not completely fix problem for eager fetch. Change in that PR checked if primary key of target class is composite but that does not matter when loading collection by foreign key. It should check if foreign key on target class is composite.

Fix from that PR did not work for me because i had entity with regular autogenerated id (single column), but foreign key referenced entity with composite primary key, like SecondLevelWithoutCompositePrimaryKey in this PR.

Checking if foreign key is composite fixed the problem for me.

Brajk19 avatar Mar 22 '24 08:03 Brajk19

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.

github-actions[bot] avatar Oct 15 '24 03:10 github-actions[bot]

Need to look into this again

beberlei avatar Oct 15 '24 06:10 beberlei

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.

github-actions[bot] avatar Jan 22 '25 03:01 github-actions[bot]

@beberlei can you take a look at PR?

Brajk19 avatar Jan 23 '25 14:01 Brajk19

Hello @greg0ire Sorry for ping. I’d really appreciate it if you could take a look when you have some time

Brajk19 avatar Feb 03 '25 19:02 Brajk19

I don't think I can be of much help here, sorry… that being said, it looks like your change breaks the build, so you should probably fix that so that the branch is clean next time Benjamin has time to look into it. Also, maybe @themash has opinions on this?

greg0ire avatar Feb 03 '25 20:02 greg0ire

@greg0ire okay, thanks anyway 😃

Brajk19 avatar Feb 03 '25 20:02 Brajk19

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.

github-actions[bot] avatar May 17 '25 03:05 github-actions[bot]

Would be great if this got fixed since it's still an issue :slightly_smiling_face:

HypeMC avatar May 18 '25 20:05 HypeMC

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.

github-actions[bot] avatar Aug 17 '25 03:08 github-actions[bot]

I'm still hoping this gets fixed :smile:

HypeMC avatar Aug 17 '25 18:08 HypeMC

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.

github-actions[bot] avatar Nov 17 '25 03:11 github-actions[bot]

Still relevant.

HypeMC avatar Nov 18 '25 11:11 HypeMC

Thanks @Brajk19 !

greg0ire avatar Nov 18 '25 20:11 greg0ire