orientdb-odm icon indicating copy to clipboard operation
orientdb-odm copied to clipboard

Binary protocol?

Open smolinari opened this issue 10 years ago • 12 comments
trafficstars

Would it make any sense to fork this project and rework it so it uses the binary interface. In other words, build it on top of the official PHP driver? AFAIK, the binary interface should perform better than the HTTP interface.

Scott

smolinari avatar Jun 03 '15 12:06 smolinari

Ok, I found this. https://github.com/doctrine/orientdb-odm/issues/121

I don't know how well the PHP driver works, but if it is at all working well, it might be worth a revisit.

Scott

smolinari avatar Jun 03 '15 12:06 smolinari

Ok, I see this project is basically dead. What a shame. I guess I'll fork it and start my own project.

Scott

smolinari avatar Jun 13 '15 06:06 smolinari

+1

ghost avatar Jun 16 '15 01:06 ghost

Hi @smolinari,

in general, adding the binary driver shouldnt be too much of a problem -- as you saw in #121. If you want to give it a shot it would be great :) though I feel that there are other parts of the mapper that would require more focus now, like finishing the persistence part.

Though contributions are always accepted :)

odino avatar Jun 16 '15 05:06 odino

Ooof! :open_mouth: ....so it is actually still an alpha and missing important features? Hmm...I didn't expect to have to work that much on it, but ok. I am excited about how OrientDB is covering bases for our project. I'd like to see a performant ODM for it too. Guess, it means doing a lot of the work too.

Scott

smolinari avatar Jun 16 '15 08:06 smolinari

TBH the HTTP protocol performs quite well, so that has never been a priority -- though, as I said, controbutions are always welcome :)

unfortunately we find very little time to proceed with things though Ive heard of some brave people using the odm out in the wild :)

On Tue, Jun 16, 2015 at 12:46 PM, Scott [email protected] wrote:

Ooof! [image: :open_mouth:] ....so it is actually still an alpha and missing important features? Hmm...I didn't expect to have to work that much on it, but ok. I am excited about how OrientDB is covering bases for our project. I'd like to see a performant ODM for it too. Guess, it means doing a lot of the work too.

Scott

— Reply to this email directly or view it on GitHub https://github.com/doctrine/orientdb-odm/issues/193#issuecomment-112341254 .

Nadalin Alessandro http://www.linkedin.com/in/alessandronadalin www.odino.org www.twitter.com/odino

odino avatar Jun 16 '15 08:06 odino

@odino, are there any specific issues noting the missing parts for finishing persistence? Or any other way to find out what is missing without sifting through the code?

Scott

smolinari avatar Jun 16 '15 13:06 smolinari

we started a conversation here but things froze, in general the whole persistence layer has to be implemented as now there is no way to actually persist a record with the manager -- though you can do it by using the HTTP client on its own.

BTW this is an example on how to use the binary protocol adapter from OrientDB-PHP :)

@davidino was working on the persistence so he might have some more insights on what we need to do there. This is the old branch, he also had some tests :) though that's a very old branch and the code can't be picked up as it is, but it's a good starting point!

odino avatar Jun 16 '15 19:06 odino

The binary driver you linked to is actually obsolete now. The new one is here and supposedly officially supported by Orient Tech.

https://github.com/orientechnologies/PhpOrient

Scott

smolinari avatar Jun 16 '15 21:06 smolinari

We could actually integrate that one then :)

On Wed, Jun 17, 2015 at 1:01 AM, Scott [email protected] wrote:

The binary driver you linked to is actually obsolete now. The new one is here and supposedly officially supported by Orient Tech. now.

https://github.com/orientechnologies/PhpOrient

Scott

— Reply to this email directly or view it on GitHub https://github.com/doctrine/orientdb-odm/issues/193#issuecomment-112568948 .

Nadalin Alessandro http://www.linkedin.com/in/alessandronadalin www.odino.org www.twitter.com/odino

odino avatar Jun 17 '15 05:06 odino

Ok. Let's see where this will go! I am not the most experienced programmer either. So please be patient with me. :smile:

Scott

smolinari avatar Jun 17 '15 05:06 smolinari

no worries man, collaboration collaboration collaboration :)

On Wed, Jun 17, 2015 at 9:48 AM, Scott [email protected] wrote:

Ok. Let's see where this will go! I am not the most experienced programmer either. So please be patient with me. [image: :smile:]

Scott

— Reply to this email directly or view it on GitHub https://github.com/doctrine/orientdb-odm/issues/193#issuecomment-112662073 .

Nadalin Alessandro http://www.linkedin.com/in/alessandronadalin www.odino.org www.twitter.com/odino

odino avatar Jun 17 '15 05:06 odino