doctrine
Added ability to call server side functions using orientdb php library
-Added ability to call server side orientdb functions -Fixed bug related to rawurl encoding database name improperly (breaks nuvolabase and some orientdb setups)
hi @rosenjon, thanks for the PR!
What about adding the test cases and changing the code a bit to follow the coding standards?
Cheers!
no prob. I'll update it tomorrow.
On Mon, Feb 4, 2013 at 8:05 PM, Alessandro Nadalin <[email protected]
wrote:
hi @rosenjon https://github.com/rosenjon, thanks for the PR!
What about adding the test cases and changing the code a bit to follow the coding standards?
Cheers!
— Reply to this email directly or view it on GitHubhttps://github.com/doctrine/orientdb-odm/pull/161#issuecomment-13113746.
I added another bug fix here. If you call the query command with a fetchplan but no limit specified, the query will fail. This is due to $limit being set to null by default in the query function. This fix defaults the limit to 20 when a fetchplan is used, thus fixing the problem. It might also make sense to set the $limit default to 20 in the query function, which would also fix the problem.
I wrote unit tests. Can you specify what needs to be fixed?
On Tuesday, May 7, 2013, Alessandro Nadalin wrote:
hi @rosenjon https://github.com/rosenjon,
would you be able to fix /provide the required testcases?
— Reply to this email directly or view it on GitHubhttps://github.com/doctrine/orientdb-odm/pull/161#issuecomment-17563878 .
I'll take a look tonight. It's been a while since I wrote this so not sure off the top of my head. Tests passed when I wrote them, so unclear what's up.
On Tuesday, May 7, 2013, Alessandro Nadalin wrote:
yep! You can see that the build on travis ci is failinghttps://travis-ci.org/doctrine/orientdb-odm/jobs/4950338, any idea what it could be?
— Reply to this email directly or view it on GitHubhttps://github.com/doctrine/orientdb-odm/pull/161#issuecomment-17568483 .