orientdb-odm icon indicating copy to clipboard operation
orientdb-odm copied to clipboard

Published 20 hours ago • verified publisher icon doctrine

[WIP] Improvements / Refactoring

Open prolic opened this issue 12 years ago • 7 comments

This is my first PR to get in touch with doctrine orientdb odm:

  • add EventManager [WIP: make use of it]
  • refactor getRepository method to check for repository class in class meta data [WIP: missing tests]

prolic avatar Jan 30 '13 18:01 prolic

totally pro this PR! :+1:

What about adding / fixing the tests?

odino avatar Jan 31 '13 07:01 odino

I am still working on this one. See the title WIP (Work in Progress).

prolic avatar Jan 31 '13 11:01 prolic

sweet!

odino avatar Jan 31 '13 12:01 odino

@nrk this PR looks awesome to me. What do you say, merge it?

@prolic thanks for the effort! :)

odino avatar May 07 '13 19:05 odino

Sorry for being so late. My initial goal to complete this is way beyond. Actually, it should be ready to merge, however I would like to make further additions, but that could also be handled in another PR.

prolic avatar May 07 '13 20:05 prolic

@prolic yup, you can go with another PR. Im waiting @nrk's feedback to merge it

odino avatar May 07 '13 20:05 odino

@odino sorry I won't be able to review @prolic's PR right now until the end of the month, but as far as I remember the last time I checked it seemed OK to me (admittedly I couldn't find the time to test or have a deeper look into the code).

nrk avatar May 08 '13 06:05 nrk