mongodb-odm icon indicating copy to clipboard operation
mongodb-odm copied to clipboard

Proxy methods in CreateCommand may be obsolete

Open jmikola opened this issue 9 months ago • 0 comments

Summary

The processProxy and processDocumentProxy methods in CreateCommand appear to be obsolete.

They were introduced in https://github.com/doctrine/mongodb-odm/commit/373966eee8bd607a86b1a3e9b77c0058384df33b prior to 1.0.0. A subsequent commit (https://github.com/doctrine/mongodb-odm/commit/56fc267459dd0b972e710b0ff1cab5fbf1859fd9, also included in 1.0.0) introduced GenerateProxiesCommand, so it's not clear if the CreateCommand methods were ever fully utilized. A related bundle commit to integrate the GenerateProxiesCommand is https://github.com/doctrine/DoctrineMongoDBBundle/commit/75d79b6e5ce933ba74b342981a2b100b996a4086 (it makes no reference to Createcommand).

For 2.0.0, https://github.com/doctrine/mongodb-odm/commit/4681d8bc2808533e18c9e1cae2c914f71575fcd6 delegated proxy generation to the separate ProxyManager library.

For additional context, see the git-blame on 2.8.x.

It appears these methods are obsolete, as they are not referenced internally, nor from the Symfony bundle. The Laminas integration doesn't appear to work with console commands at all.

jmikola avatar Apr 29 '24 14:04 jmikola