migrations icon indicating copy to clipboard operation
migrations copied to clipboard

Drop support for silencing errors about DDL in transactions

Open greg0ire opened this issue 2 years ago • 4 comments

I hesitated between this and removing the transaction helper entirely, but I think this solution will result in less support for us. Let me know if you think I should remove the transaction helper.

greg0ire avatar Jan 11 '23 09:01 greg0ire

If the helper class is kept in 4.0, it can only be removed in a 5.0 release, right? It doesn't seem to be widely in use now.

SenseException avatar Jan 13 '23 23:01 SenseException

I think the choice is between removing it in 4.0, or keeping it forever, for DX reasons.

greg0ire avatar Jan 14 '23 09:01 greg0ire

The method naming is odd now. The names end with IfInTransaction which suggests that I can also safely call the method without an active transaction. But that's not the case anymore.

derrabus avatar Jan 14 '23 11:01 derrabus

Ok, I'll switch to just commit and rollback then.

greg0ire avatar Jan 14 '23 12:01 greg0ire