dbal icon indicating copy to clipboard operation
dbal copied to clipboard

Filter 'public' schema from listSchemaNames

Open allan-simon opened this issue 3 years ago • 3 comments

Fixes #5596

Q A
Type bug
Fixed issues #5596

Summary

Filter 'public' schema from listSchemaNames

As postgresql expects public to be existing as it is the default schema https://www.postgresql.org/docs/current/ddl-schemas.html#DDL-SCHEMAS-CATALOG Application code is not supposed to play with, the same way as we don't return other system-related schemas

allan-simon avatar Aug 17 '22 23:08 allan-simon

@morozov I disagree with your position as you've completly ignored my link to other issues stating it erronously does "CREATE SCHEMA" , so your fix just go back to the previous status quo , without further explanation which is a bit rude ...

allan-simon avatar Aug 21 '22 18:08 allan-simon

@allan-simon your pull request claims to fix #5596 which should be fixed by #5604. Can we close that issue?

If you want to address other issues, please feel free to report them and work on addressing them. Do you want this pull request to be reopened?

morozov avatar Aug 21 '22 22:08 morozov

@morozov yes #5596 symptoms are fixed , I'm closing it , I've now opened #5609 to follow up on this.

and yes this PR is still relevant and can be reopened

allan-simon avatar Aug 21 '22 23:08 allan-simon

Closing as all related DBAL issues are closed. Before proposing any related changes again, please see https://github.com/doctrine/dbal/issues/5609#issuecomment-1257020519.

morozov avatar Sep 24 '22 17:09 morozov