dbal icon indicating copy to clipboard operation
dbal copied to clipboard

Fix SqlitePlatform FK compare for quoted columns

Open mvorisek opened this issue 2 years ago • 1 comments

Q A
Type bug
Fixed issues n/a

Summary

The previous FKs are dropped if the $fromTable has quoted columns - https://github.com/doctrine/dbal/blob/3.3.7/src/Platforms/SqlitePlatform.php#L1261

all other column names are unquoted, thus the columns from $fromTable must be as well

also make some SqlitePlatform methods protected, so (hot)fixing issues like these is possible on the dependent packages

mvorisek avatar Jul 13 '22 22:07 mvorisek

Please document the problem and provide an integration test.

morozov avatar Jul 14 '22 15:07 morozov

Closing due to the lack of feedback.

morozov avatar Aug 12 '22 01:08 morozov

I was on holidays, please reopen this issue, although the issue should be obvious (as the 2nd name in the comparsion is unquoted), I am happy to provide a test.

mvorisek avatar Aug 12 '22 20:08 mvorisek

Closing due to the lack of feedback.

morozov avatar Sep 18 '22 19:09 morozov