dbal
dbal copied to clipboard
doctrine
Fix incorrect handling of transactions using deferred constraints
Closes #3424 as it's very long and outdated so I decided to start again here
| Q | A |
|---|---|
| Type | bug/feature |
| BC Break | yes |
| Fixed issues | #3423, https://github.com/doctrine/orm/issues/7545 |
Summary
Rollback is being called when outside of a transaction when using e.g. deferred constraints or when using ORM and database throws error like https://www.cockroachlabs.com/docs/v21.1/transaction-retry-error-reference.html#retry_write_too_old which is then effectively hidden after PDO's There's no active transaction.
@simPod thank you for the patch. I remember looking into this issue a couple of years ago. IIRC, it wasn't something trivial, so it may take some time before I post the review. But rest assured, it won't be ignored.
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closing as this pull request hasn't received significant updates in almost a year and is far from being done.
@morozov I was waiting for the feedback
IIRC it was fully done and functional from my side.
IIRC, it had a failing build for all this time. Didn't it? Let's reopen and double-check.
I think it failed because of oracle platform or something similar. And it was related to this IIRC https://github.com/doctrine/dbal/pull/4846#discussion_r748900007
On Sun, Sep 18, 2022, 21:57 Sergei Morozov @.***> wrote:
IIRC, it had a failing build for all this time. Didn't it? Let's reopen and double-check.
— Reply to this email directly, view it on GitHub https://github.com/doctrine/dbal/pull/4846#issuecomment-1250376374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQAJJF4OUAS7WNOFB6YO3V65X4NANCNFSM5FI2IL7A . You are receiving this because you were mentioned.Message ID: @.***>
If you plan to continue working on this patch, please ~~retarget it against 3.5.x,~~ rebase and address the build issues.
It looks like the changes requested in https://github.com/doctrine/dbal/pull/4846#discussion_r733215344 got lost during the rebase.
I haven't started reviewing the patch yet. Let's get https://github.com/doctrine/dbal/pull/4846 done and this one rebased on top first.
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
D ys bs
On Fri, Jun 16, 2023, 06:01 github-actions[bot] @.***> wrote:
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
— Reply to this email directly, view it on GitHub https://github.com/doctrine/dbal/pull/4846#issuecomment-1594021564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQAJJ344WN4BIEGRJKYSLXLPEBNANCNFSM5FI2IL7A . You are receiving this because you were mentioned.Message ID: @.***>
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
.
On Sat, Sep 16, 2023, 06:01 github-actions[bot] @.***> wrote:
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.
— Reply to this email directly, view it on GitHub https://github.com/doctrine/dbal/pull/4846#issuecomment-1722116081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQAJN62KQ2QROWMBMXIXLX2UJAZANCNFSM5FI2IL7A . You are receiving this because you were mentioned.Message ID: @.***>
Can somebody fill me in what's up with this PR? It does not look like the kind of change we would accept on the 4.0.x branch.
@derrabus see https://github.com/doctrine/orm/issues/7545 Current behavior section. The problem is that we're trying to rollback already rollbacked transaction and therefore the underlying issue (like unique constraint violation) is suppressed by There's no active transaction.
Understood. Let me take over the review then. But as I said, we don't accept this kind of change on the 4.0.x branch. You need to target 3.7.x currently if this is a bugfix and 3.8.x otherwise.
Great. I have rebased this like trillion times over the years so I'm glad there's a promise of a movement now. I'll target 3.8.x I guess.
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.