Problem with TEXT type in MSSQL due to VARCHAR(MAX) instead of NVARCHAR(MAX)

[cfales]

The below issue was set for milestone 2.5.2 but was marked as Closed - Incomplete. DBAL-1233: TEXT type in MSSQL should be NVARCHAR(MAX) not VARCHAR(MAX)

To my knowledge the issue remains (as there are other similar problems reported eg. DBAL-1823: Doctrine2 + pdo_sqlsrv the createQueryBuilder() Order By with varchar field does not work)

This is an issue that is affected our deployment.

Could someone have a look and see if this is a problem that can be addressed in an update?

[mwey]

+1

[Ocramius]

Ref: https://github.com/doctrine/dbal/issues/1182

[Ocramius]

Ref: https://github.com/doctrine/dbal/issues/1351

[PatrickLouys]

https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Schema/SQLServerSchemaManager.php#L75

Introduced here https://github.com/doctrine/dbal/commit/56c0806d08d605d46cbb7cacb6b2254cb48c061f by @deeky666

Could this be fixed by just switching varchar to nvarchar? Or is there a reason why varchar was used?

[rwitchell]

+1

[hockdudu]

Is there an update on this issue? The pull request #3262 was closed without being merged, but I don't quite understand why.

[Ocramius]

@hockdudu looks like the original author deleted their fork, hence why the PR was closed.

Send one WITH a test, and then it shall be considered.