data-fixtures icon indicating copy to clipboard operation
data-fixtures copied to clipboard

Version 2: Make executors and purgers final

Open dbu opened this issue 6 years ago • 3 comments

This is a follow up to #289 (and will show the changes from #289 until it is merged) to make purgers and executors final and add return type and method type declarations where possible. i also remove pointless phpdoc comments.

This bumps the version to 2 - i suggest to keep this open and wait with merging until you feel ready to start the 2.0 version.

dbu avatar Mar 20 '18 07:03 dbu

Looking good from here. Something went completely sideways with composer update though. Also, do we want to stop improvements on the 1.x series, @doctrine/doctrinecore?

Ocramius avatar Mar 20 '18 09:03 Ocramius

i rebased on master, now the diff is better readable.

i just noticed that there is a 2.0 branch with lots of commits, but also way behind master... shall i change this MR to go against the 2.0 branch? shall i cherry-pick this change, or does somebody want to first merge master into 2.0 to have it more up to date?

or should we create a 1.3 maintenance branch from master and then merge 2.0 to master to get 2.0 rolling?

dbu avatar Mar 20 '18 09:03 dbu

@dbu that depends on @guilhermeblanco: he worked a lot on fixtures 2.x, but we never got to push it through...

Ocramius avatar Mar 20 '18 09:03 Ocramius

Closing in favor of #458.

derrabus avatar Dec 16 '23 16:12 derrabus