Some data collectors are gone

[garak]

I see that version 4 dropped PrettyDataCollector and StandardDataCollector, and added CommandDataCollector. Unfortunately, I can't find any mention of this in CHANGELOG-4.0 nor in UPGRADE-4.0. What is the supposed upgrade path? Can we add some instructions?

[alcaeus]

I apologise for the delayed response, this issue managed to hide in between my notifications.

The PrettyDataCollector previously attempted to reproduce commands to be used in the MongoDB shell for anything that was executed through doctrine/mongodb. With the new APM-based logging functionality, we're no longer looking at such operations, but only at commands (hence CommandDataCollector). These will always be run through db.runCommand(...) in the MongoDB shell, which is also why we've opted to not add a data collector that changes the output.

The CommandDataCollector prints the command document as it was sent to the server. You can copy that and directly paste it into the shell to reproduce its results.

It could very well be that I forgot to mention this in the documentation. I won't get to it until next week, but I'll gladly review and merge a PR to the 3.6 or 4.0 branch depending on where we introduced the upgrade files. Thanks for raising this issue!

[markitosgv]

Im trying executing some profiling commands, but it fails, ie:

db.runCommand({"find":"Purchases","filter":{"_id":{"$in":[{"$oid":"5de92135ebd06910835a25c7"}]}}})

error: cannot nest $ under $in

or

db.runCommand({"find":"Purchases","filter":{"_id":{"$oid":"5de92135ebd06910835a25c7"}}})

error: unknown operator: $oid

Before PrettyDataCollector worked nice

[alcaeus]

Ah. The $oid portion is how ObjectID is serialised. This won't work in the MongoDB shell and needs to be changed. I'll see what I can do there 👍

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[markitosgv]

Any new idea about this @alcaeus ?

[alcaeus]

Sorry, I haven't gotten to it at all for now.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[markitosgv]

any updates about change $oid? thanks!

[malarzm]

I'll reopen this for when @alcaeus is back

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[malarzm]

Bad bot

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[markitosgv]

reopen please :)