DoctrineFixturesBundle icon indicating copy to clipboard operation
DoctrineFixturesBundle copied to clipboard

Fix deprecations and ensure compatibility with Symfony 6.4 (#420) for…

Open joscraw opened this issue 1 year ago • 4 comments

Fix deprecations and ensure compatibility with Symfony 6.4 (#420)

  • Updated SymfonyFixturesLoader to conditionally set the container:

    • Added a class_exists check for ContainerAwareInterface in the addFixture method.
    • Passed bool and ContainerInterface to the constructor of SymfonyFixturesLoader.
  • Updated DoctrineFixturesExtension for future compatibility:

    • Added ?ConfigurationInterface return type to getConfiguration method.
    • Replaced HttpKernelExtension with Symfony\Component\DependencyInjection\Extension\Extension.
  • Fixed tests to correctly initialize SymfonyFixturesLoader:

    • Updated LoadDataFixturesDoctrineCommandTest to pass correct parameters to SymfonyFixturesLoader.
  • Implemented isUninitializedObject method in EntityManagerDecorator for future Doctrine compatibility.

These changes address deprecation warnings and ensure compatibility with Symfony 6.4 and future versions.

joscraw avatar Jul 14 '24 15:07 joscraw

bump 🤜

craigh avatar Aug 27 '24 18:08 craigh

It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those.

greg0ire avatar Aug 27 '24 18:08 greg0ire

@joscraw any chance you can update this to fix the failing jobs?

craigh avatar Sep 04 '24 15:09 craigh

@craigh Hey guys! Sorry, I was out for a bit. Yup I'm on it! I'll take care of it here in a few min.

joscraw avatar Sep 04 '24 15:09 joscraw

Thank you! When do you think it will be merged?

stanislav-oop avatar Nov 04 '24 12:11 stanislav-oop

I am reviewing the depreciations (LTS symfony 6.4) and I can see the depreciation is coming from just the doctrine fixtures without any other custom code. Can not find any other workaround.

stanislav-oop avatar Nov 04 '24 15:11 stanislav-oop

Can not find any other workaround.

Does that fix the deprecations for you?

"doctrine/doctrine-fixtures-bundle": "^4@dev"

derrabus avatar Nov 04 '24 18:11 derrabus

Yes it does, but for the minimum-stablity

stanislav-oop avatar Nov 04 '24 19:11 stanislav-oop

the minimum-stablity

That's fixable on our side. 🙉

@greg0ire @SenseException Shall we release 4.0?

derrabus avatar Nov 04 '24 19:11 derrabus

Sure!

greg0ire avatar Dec 05 '24 18:12 greg0ire

@derrabus Releasing the 4.0.x branch instead def makes more sense to me! Thanks guys!

joscraw avatar Dec 05 '24 21:12 joscraw