DoctrineExtensions icon indicating copy to clipboard operation
DoctrineExtensions copied to clipboard

Replace the behat/transliterator with symfony/string for the Sluggable extension

Open mbabker opened this issue 6 months ago • 2 comments

Fixes #2941

mbabker avatar May 10 '25 22:05 mbabker

+1 thanks for the fix !

Renrhaf avatar May 22 '25 14:05 Renrhaf

When can we expect this to be done?

gabrielius914 avatar Jun 02 '25 08:06 gabrielius914

Up, thanks

dmitryuk avatar Jul 10 '25 09:07 dmitryuk

@phansys Could you please give some feedback on this, if you have some time.

Chris53897 avatar Jul 17 '25 12:07 Chris53897

Update, please

Atantares avatar Jul 23 '25 07:07 Atantares

Is there anything we can do to help merge this PR ?

smnandre avatar Jul 28 '25 02:07 smnandre

@phansys seems like you made the latests release, could you take a look at this PR ? (And maybe retrigger the CI ?)

@mbabker Are you still interested by this PR ? Do you know what is missing to get a green CI ?

VincentLanglet avatar Aug 24 '25 13:08 VincentLanglet

Do you know what is missing to get a green CI ?

The failing CI has nothing to do with this PR, I know I have one that fixes the main failure but at this point there's probably more stuff from newer ORM, DBAL, and MongoDB ODM releases that probably create new SA issues.

mbabker avatar Aug 26 '25 23:08 mbabker

Do you know what is missing to get a green CI ?

The failing CI has nothing to do with this PR, I know I have one that fixes the main failure but at this point there's probably more stuff from newer ORM, DBAL, and MongoDB ODM releases that probably create new SA issues.

If needed I will be able to help on solve the SA issues.

But first I think we need to find an active maintainer. I see you're listed in the sponsor list of this repository, do you have merge rights @mbabker ? If not do you have any contact about someone which has ? I feel like this lib is lacking maintainer/activity...

VincentLanglet avatar Aug 27 '25 14:08 VincentLanglet

If needed I will be able to help on solve the SA issues.

I'm pretty sure the only current SA issues are from the releases of ORM 3.4 and MongoDB ODM 2.11 (the ODM bits are covered in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2945, the ORM stuff might be covered in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2966 otherwise that shouldn't be anything more than reversing some inline @phpstan-ignore bits). So the SA and the automated tests aren't actually in too terrible of shape, but the ODM thing is what's causing the hard test failures on current PHP versions.

But first I think we need to find an active maintainer. I see you're listed in the sponsor list of this repository, do you have merge rights @mbabker ?

If I did, there'd be a lot more recently merged PRs and releases. I'm just the lucky one who's done a lot of reviewing and updating the library over the last year or so and someone else decided to add me to the sponsor list (which I'm absolutely grateful for, but also know I didn't ask for it).

mbabker avatar Aug 27 '25 15:08 mbabker

If I did, there'd be a lot more recently merged PRs and releases. I'm just the lucky one who's done a lot of reviewing and updating the library over the last year or so and someone else decided to add me to the sponsor list (which I'm absolutely grateful for, but also know I didn't ask for it).

If you're ok with it, it could be interesting to contact existing maintainer to add you (?)

VincentLanglet avatar Aug 27 '25 15:08 VincentLanglet

Sorry for the delay in responding. I've been pretty busy at work these weeks.

I'll try to take a look on this.

phansys avatar Sep 13 '25 23:09 phansys

I am closing and reopening this PR in order to trigger fresh pipelines.

phansys avatar Sep 13 '25 23:09 phansys

If it helps @phansys I rebased the PR in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2985

Also, did you consider sharing some maintainer rights with mbabker since he seems active/invested in this repository (?)

VincentLanglet avatar Sep 14 '25 09:09 VincentLanglet