DoctrineExtensions
DoctrineExtensions copied to clipboard
Replace the behat/transliterator with symfony/string for the Sluggable extension
Fixes #2941
+1 thanks for the fix !
When can we expect this to be done?
Up, thanks
@phansys Could you please give some feedback on this, if you have some time.
Update, please
Is there anything we can do to help merge this PR ?
@phansys seems like you made the latests release, could you take a look at this PR ? (And maybe retrigger the CI ?)
@mbabker Are you still interested by this PR ? Do you know what is missing to get a green CI ?
Do you know what is missing to get a green CI ?
The failing CI has nothing to do with this PR, I know I have one that fixes the main failure but at this point there's probably more stuff from newer ORM, DBAL, and MongoDB ODM releases that probably create new SA issues.
Do you know what is missing to get a green CI ?
The failing CI has nothing to do with this PR, I know I have one that fixes the main failure but at this point there's probably more stuff from newer ORM, DBAL, and MongoDB ODM releases that probably create new SA issues.
If needed I will be able to help on solve the SA issues.
But first I think we need to find an active maintainer. I see you're listed in the sponsor list of this repository, do you have merge rights @mbabker ? If not do you have any contact about someone which has ? I feel like this lib is lacking maintainer/activity...
If needed I will be able to help on solve the SA issues.
I'm pretty sure the only current SA issues are from the releases of ORM 3.4 and MongoDB ODM 2.11 (the ODM bits are covered in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2945, the ORM stuff might be covered in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2966 otherwise that shouldn't be anything more than reversing some inline @phpstan-ignore bits). So the SA and the automated tests aren't actually in too terrible of shape, but the ODM thing is what's causing the hard test failures on current PHP versions.
But first I think we need to find an active maintainer. I see you're listed in the sponsor list of this repository, do you have merge rights @mbabker ?
If I did, there'd be a lot more recently merged PRs and releases. I'm just the lucky one who's done a lot of reviewing and updating the library over the last year or so and someone else decided to add me to the sponsor list (which I'm absolutely grateful for, but also know I didn't ask for it).
If I did, there'd be a lot more recently merged PRs and releases. I'm just the lucky one who's done a lot of reviewing and updating the library over the last year or so and someone else decided to add me to the sponsor list (which I'm absolutely grateful for, but also know I didn't ask for it).
If you're ok with it, it could be interesting to contact existing maintainer to add you (?)
Sorry for the delay in responding. I've been pretty busy at work these weeks.
I'll try to take a look on this.
I am closing and reopening this PR in order to trigger fresh pipelines.
If it helps @phansys I rebased the PR in https://github.com/doctrine-extensions/DoctrineExtensions/pull/2985
Also, did you consider sharing some maintainer rights with mbabker since he seems active/invested in this repository (?)