DoctrineExtensions icon indicating copy to clipboard operation
DoctrineExtensions copied to clipboard

Closing the API by marking classes as final and internal

Open phansys opened this issue 3 years ago • 4 comments

TODO:

  • [x] Resolve the cases where the test classes are extending classes marked as final.

phansys avatar Nov 12 '21 13:11 phansys

Codecov Report

Base: 80.28% // Head: 80.28% // No change to project coverage :thumbsup:

Coverage data is based on head (682fc3c) compared to base (4a6a2be). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2301   +/-   ##
=========================================
  Coverage     80.28%   80.28%           
  Complexity     3166     3166           
=========================================
  Files           159      159           
  Lines          7729     7729           
=========================================
  Hits           6205     6205           
  Misses         1524     1524           
Impacted Files Coverage Δ
src/Blameable/BlameableListener.php 72.22% <ø> (ø)
src/Blameable/Mapping/Driver/Annotation.php 77.77% <ø> (ø)
src/Blameable/Mapping/Driver/Xml.php 0.00% <ø> (ø)
src/Blameable/Mapping/Driver/Yaml.php 0.00% <ø> (ø)
src/IpTraceable/IpTraceableListener.php 100.00% <ø> (ø)
src/IpTraceable/Mapping/Driver/Annotation.php 75.00% <ø> (ø)
src/IpTraceable/Mapping/Driver/Xml.php 0.00% <ø> (ø)
src/IpTraceable/Mapping/Driver/Yaml.php 0.00% <ø> (ø)
...oggable/Document/Repository/LogEntryRepository.php 95.00% <ø> (ø)
.../Loggable/Entity/Repository/LogEntryRepository.php 96.49% <ø> (ø)
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Nov 29 '21 16:11 codecov-commenter

@phansys do you want to take a look at this before releasing next minor version or do we defer this to the next one?

franmomu avatar Jan 06 '22 09:01 franmomu

@phansys do you want to take a look at this before releasing next minor version or do we defer this to the next one?

I'd like to merge this PR this week, but as I'm not able to confirm this expectation, I'd say you should not wait. Thank you!

phansys avatar Jan 06 '22 15:01 phansys

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 05 '22 16:07 github-actions[bot]