DoctrineExtensions icon indicating copy to clipboard operation
DoctrineExtensions copied to clipboard

[Blameable] Int is not a valid Doctrine type mapping

Open tezvi opened this issue 5 years ago • 4 comments

https://github.com/Atlantic18/DoctrineExtensions/blob/ee6e427c759da76b65597870e2bae36fc7b09631/lib/Gedmo/Blameable/Mapping/Driver/Annotation.php#L29-L33

Is int value a valid Doctrine mapping type? It seems that "integer" should be used instead. I've managed to defined custom doctrine type in symfony configuration so this works for me at framework level:

doctrine:
    dbal:
        types:
            int: Doctrine\DBAL\Types\IntegerType

However, it would be nice to have "integer" value in $validTypes collection as well, so everyone can be happy :)

Something similar is reported here but closed without proper resolution https://github.com/Atlantic18/DoctrineExtensions/issues/1137

tezvi avatar Apr 04 '19 11:04 tezvi

It looks like @Padam87 addressed this in PR #1533, but it targeted a previous attempt at a 3.0 release which went abandoned.

I'll see if it can be cherry picked into 2.4.x. Thank you for the issue.

AkenRoberts avatar Apr 14 '19 20:04 AkenRoberts

This seems to be quite strange - I suddenly updated today from 1f4899c5d3de8b9cdc5189a46ea9b94665be5f09 to f3bdc16fc2e793c37c1fefb1e4fa2f8a0a59edfc via 1f4899c...f3bdc16.

At the time of 1f4899c5d3de8b9cdc5189a46ea9b94665be5f09, integer was included in Annotation::$validTypes, now it itsn't. But I cannot determine when or in which commit this was removed.

theoboldt avatar May 03 '19 13:05 theoboldt

Will this be merged? I still have the same problem mentioned by @theoboldt :(

Marcelixoo avatar Aug 30 '20 18:08 Marcelixoo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 05 '22 10:05 github-actions[bot]