code-tours-github icon indicating copy to clipboard operation
code-tours-github copied to clipboard

GitLab support

Open rsteenwyk opened this issue 4 years ago • 3 comments
trafficstars

First off, thanks for this extension, very cool!

Just curious how hard it would be to add support for Gitlab/internal instances of Gitlab?

rsteenwyk avatar May 12 '21 13:05 rsteenwyk

Hi!

I'm not 100% sure how hard it would be to add support for gitlab. Just a few thoughts:

  • If we want to support private gitlab instances, then we can't list the URLs we inject in anymore (so either we inject in all pages, or we let the users decide on which domains they want to use the extension)
  • Most of the logic can probably be reused, but we'd need to check if it's possible to access the files content on gitlab with simple requests from the extension (is the same workflow as the one we use on Github usable?)

I don't think we're speaking about too much work but I'll need to investigate a little bit. At least for the official Gitlab. I guess we'd start there and think about private instances later on, if it works fine. Do you know of any repos public where there are code tours available? Otherwise I'll create my own 🙂

qmenoret avatar May 25 '21 08:05 qmenoret

I actually went ahead and created my own repo on gitlab. It doesn't look too complicated but I'll need to refactor quite a bit to make it work without duplicating all the logic so I don't have an ETA just yet. I'll update here once I have a prototype and would be super happy to have you as a beta tester 😉

qmenoret avatar May 25 '21 18:05 qmenoret

Sounds good, happy to try it out on my internal instance when you get to that stage.

rsteenwyk avatar May 25 '21 18:05 rsteenwyk