php-etl icon indicating copy to clipboard operation
php-etl copied to clipboard

Add system by worklow

Open silverpark opened this issue 10 years ago • 7 comments

I propose to you to add a system of workflow like that. We can call several workflow successively.

silverpark avatar Mar 04 '14 13:03 silverpark

this seems to be a great idea! We can merge what you have already, and potentially improve this if needed.

Can you add some tests if possible ? I d'ont know if you successfully get it to work, so it would be an insurance.

thanks!

docteurklein avatar Mar 05 '14 15:03 docteurklein

Yes, we can merge, I respected your indentations and comments. I working about functional test with phpSpec on Wokflow.

It's a good new.

silverpark avatar Mar 05 '14 16:03 silverpark

I have rectify error code in Knp/ETL/Workflow.php and I have done the functionnal test with spec/Knp/ETL/WorkflowSpec.php but I have difficulties to do : $dispatcher->dispatch('workflow.post_extract', Argument::type('Symfony\Component\EventDispatcher\GenericEvent'))->shouldBeCalled();

Could you help me ?

He said to me : ! should dispatch post extract method call: Double\Symfony\Component\EventDispatcher\EventDispatcher\P10->dispatch("workflow.post_transform", Symfony\Component\EventDispatcher\GenericEvent:000000002628e2da000000001a2bd7a0) was not expected. Expected calls are: - dispatch(exact("workflow.post_extract"), type(Symfony\Component\EventDispatcher\GenericEvent))

I have post a question in stackoverflow and I have been a answer : http://stackoverflow.com/questions/22254432/phpspec-i-would-like-call-shouldbecalled-on-a-dispatcher I have look at an exemple in the call : https://github.com/phpspec/phpspec/blob/master/spec/PhpSpec/Runner/ExampleRunnerSpec.php

silverpark avatar Mar 10 '14 09:03 silverpark

I have finish to add functionnal test with success. I have found how to do for add test about event dispatcher.

I wait your validation code and indentation for merge.

silverpark avatar Mar 10 '14 15:03 silverpark

awesome, thanks!

docteurklein avatar Aug 30 '14 08:08 docteurklein

and sorry for the delay.

docteurklein avatar Aug 30 '14 08:08 docteurklein

oops, it seems you need to rebase your branch in order to merge.

docteurklein avatar Aug 30 '14 08:08 docteurklein