php-etl
php-etl copied to clipboard
Add system by worklow
I propose to you to add a system of workflow like that. We can call several workflow successively.
this seems to be a great idea! We can merge what you have already, and potentially improve this if needed.
Can you add some tests if possible ? I d'ont know if you successfully get it to work, so it would be an insurance.
thanks!
Yes, we can merge, I respected your indentations and comments. I working about functional test with phpSpec on Wokflow.
It's a good new.
I have rectify error code in Knp/ETL/Workflow.php and I have done the functionnal test with spec/Knp/ETL/WorkflowSpec.php but I have difficulties to do : $dispatcher->dispatch('workflow.post_extract', Argument::type('Symfony\Component\EventDispatcher\GenericEvent'))->shouldBeCalled();
Could you help me ?
He said to me : ! should dispatch post extract method call: Double\Symfony\Component\EventDispatcher\EventDispatcher\P10->dispatch("workflow.post_transform", Symfony\Component\EventDispatcher\GenericEvent:000000002628e2da000000001a2bd7a0) was not expected. Expected calls are: - dispatch(exact("workflow.post_extract"), type(Symfony\Component\EventDispatcher\GenericEvent))
I have post a question in stackoverflow and I have been a answer : http://stackoverflow.com/questions/22254432/phpspec-i-would-like-call-shouldbecalled-on-a-dispatcher I have look at an exemple in the call : https://github.com/phpspec/phpspec/blob/master/spec/PhpSpec/Runner/ExampleRunnerSpec.php
I have finish to add functionnal test with success. I have found how to do for add test about event dispatcher.
I wait your validation code and indentation for merge.
awesome, thanks!
and sorry for the delay.
oops, it seems you need to rebase your branch in order to merge.