docsify icon indicating copy to clipboard operation
docsify copied to clipboard

Feat/5.0

Open QingWei-Li opened this issue 6 years ago • 4 comments

Please makes sure these boxes are checked before submitting your PR, thank you!

  • [x] Make sure you are merging your commits to master branch.
  • [x] Add some descriptions and refer relative issues for you PR.
  • [x] DO NOT include files inside lib directory.
  • New Feature: Generate static html #136 ref https://github.com/docsifyjs/docsify-cli/pull/55
  • New Markdown Syntax: Friendly doc Helpers, #413

The other two features I don't plan to develop. Not much effect.

@docsifyjs/core @jhildenbiddle

First of all, I have to apologize.

I haven't read the issues for a long time and haven't noticed your email. I may have to leave this project.

I have promoted @timaschew to owner and hope that you can continue to maintain docsify.

This is my last contribution to docsify. If you feel that there is no problem, then I will release 5.0. And give the release permission to your.

QingWei-Li avatar Mar 31 '19 08:03 QingWei-Li

@timaschew If you need permission to post, please let me know your npm account.

QingWei-Li avatar Mar 31 '19 08:03 QingWei-Li

As @jhildenbiddle mentioned here: https://github.com/docsifyjs/docsify/issues/657#issuecomment-458341229 I agree with him to delay this PR (bump to 5.0) until some bugs are fixed which should be released as 4.x Merging this without bumping the major version seems not an option since this PR contains some breaking changes like the syntax for the helpers.

timaschew avatar Mar 31 '19 08:03 timaschew

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 04 '20 07:02 stale[bot]

Develop has diverged from this PR. There's 11 files with conflicts. What do we want to do?

I think we either

  • take effort to clean up the PR
  • or close it, and open a new branch

Either way, we should not let existing branches get stale. After each pull request is merged, we should merge develop into the breaking-release branch (that is, if we want to keep the breaking changes).

trusktr avatar Jun 08 '20 02:06 trusktr