docsify icon indicating copy to clipboard operation
docsify copied to clipboard

prevent a try catch from hiding a build error, also fix build/emoji.js in Windows

Open trusktr opened this issue 2 years ago • 2 comments

Summary

I removed the try-catch from build/emoji.js because it prevented the output from being helpful when there was an error, and made the script exit with zero instead of non-zero upon error so a build would pass which would make it even less obvious that there was an error.

Also improve the regex in build/emoji.js so that it works with CRLF or LF just in case of... Windows.

Related issue, if any:

  • https://github.com/docsifyjs/docsify/issues/2290

What kind of change does this PR introduce?

Build-related changes Repo settings

For any code change,

  • [x] Related documentation has been updated, if needed
  • [x] Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

N/A

trusktr avatar Oct 22 '23 05:10 trusktr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 5:32pm

vercel[bot] avatar Oct 22 '23 05:10 vercel[bot]

@trusktr --

Can we close this now that #2288a and #2436 have been merged?

jhildenbiddle avatar May 28 '24 20:05 jhildenbiddle