docsify icon indicating copy to clipboard operation
docsify copied to clipboard

activate sidebar on resetEvents

Open andy-held opened this issue 1 year ago • 1 comments

Summary

When no fetchis done, the active sidebar element is not updated when a link is clicked. This is changed in this commit by calling getAndActive in $resetEvents.

This is shown in the videos below. In both videos, the 'QuickStart' sidebar element was selected, then the 'Initialize' sub-sidebar child of 'Quickstart' and then the parent sidebar element, 'Quickstart' again.

Current behavior

Clicking on a sub-sidebar, then clicking on the parent sidebar again results in no element being 'active' .

Screencast from 14.07.2023 17:51:07.webm

Behavior after fix

Clicking on a sub-sidebar, then clicking on the parent sidebar again results in the sidebar element being 'active' .

Screencast from 14.07.2023 17:50:45.webm

What kind of change does this PR introduce?

Bugfix

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

Related issue, if any:

Tested in the following browsers:

  • [x] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

andy-held avatar Jul 14 '23 16:07 andy-held

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 4:03pm

vercel[bot] avatar Jul 14 '23 16:07 vercel[bot]