docsify icon indicating copy to clipboard operation
docsify copied to clipboard

update: enhance the navigating.

Open Koooooo-7 opened this issue 3 years ago • 3 comments

Summary

Enhance the navigating stuff on sidebar. When click the same anchor, it won't trigger the hashchange event, even though it already scroll down to other part of content. close #1899

What kind of change does this PR introduce?

Bugfix

For any code change,

  • [ ] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

FYI, will add the tests later.

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

Koooooo-7 avatar Oct 07 '22 21:10 Koooooo-7

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 9:11PM (UTC)

vercel[bot] avatar Oct 07 '22 21:10 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b48ca1869df9e90b430fb87dd13f829c72bc3bdf:

Sandbox Source
docsify-template Configuration
muddy-sun-fcsrxh Issue #1899

codesandbox-ci[bot] avatar Oct 07 '22 21:10 codesandbox-ci[bot]

After more thoughts on it, This PR needs pending for refine the behavior and concern on active changes actions. If directly treat all the clink change to trigger hashChangeEvent seems unreasonable.

Koooooo-7 avatar Oct 26 '22 08:10 Koooooo-7