docsify icon indicating copy to clipboard operation
docsify copied to clipboard

Published 20 hours ago • verified publisher icon docsifyjs

fix: When alias contains parameters, append ext error

Open sy-records opened this issue 2 years ago • 7 comments

Summary

As mentioned in #1854, if the URL used by the alias contains parameters, we will add the 'ext' configuration item incorrectly

What kind of change does this PR introduce?

Bugfix

For any code change,

  • [ ] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Fix #1854

Tested in the following browsers:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

sy-records avatar Aug 12 '22 01:08 sy-records

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Aug 12, 2022 at 7:10AM (UTC)

vercel[bot] avatar Aug 12 '22 01:08 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c5a0cbc03f0e8ec7382ea44f1bdeaff6226bc82:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Aug 12 '22 01:08 codesandbox-ci[bot]

See comment. Basically this still has other problems. The solution is to handle paths and queries separately Hi, Any new updates on this issue. We were working on federating multiple repo's readme.md files to a single documentation page. Fixing this error would help a lot.

SumithChandran avatar Sep 06 '22 09:09 SumithChandran

See comment. Basically this still has other problems. The solution is to handle paths and queries separately Hi, Any new updates on this issue. We were working on federating multiple repo's readme.md files to a single documentation page. Fixing this error would help a lot.

@SumithChandran hi, sorry for taking long. Did you find a solution? I commented on a direction we should look at. We just need to handle all the URL parts correctly, f.e. get all the parts of the URL, do what we need with only the path part, then put everything back together properly.

trusktr avatar Jan 26 '23 06:01 trusktr

See comment. Basically this still has other problems. The solution is to handle paths and queries separately Hi, Any new updates on this issue. We were working on federating multiple repo's readme.md files to a single documentation page. Fixing this error would help a lot.

@SumithChandran hi, sorry for taking long. Did you find a solution? I commented on a direction we should look at. We just need to handle all the URL parts correctly, f.e. get all the parts of the URL, do what we need with only the path part, then put everything back together properly.

@trusktr , no I haven't found anything solution.

SumithChandran avatar Jan 27 '23 16:01 SumithChandran

Any chance this will get done soon? I've actually never committed to a public repo, but this looks pretty straightforward. I'd be willing to try.

zomgbre avatar Jun 07 '23 16:06 zomgbre

Any chance this will get done soon? I've actually never committed to a public repo, but this looks pretty straightforward. I'd be willing to try.

@zomgbre willing to take a stab at it? We haven't circled back yet

trusktr avatar Sep 19 '23 16:09 trusktr